git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pierre Habouzit <madcoder@debian.org>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Bernt Hansen <bernt@alumni.uwaterloo.ca>
Subject: Re: [AGGREGATED PATCH] Fix in-place editing functions in convert.c
Date: Fri, 5 Oct 2007 19:24:25 +0200	[thread overview]
Message-ID: <20071005172425.GD31413@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0710050933330.23684@woody.linux-foundation.org>

Hi Linus.

> No, following patch is fundamentally broken - it's not even a good 
> starting point. It's bad, bad, bad.
> 
> It's also broken in another way: we want it to be really easy to use 
> strbuf's as normal C strings.
> 
> Yes, many (totally idiotic and broken) interfaces think it's so important 
> to "protect" their internal data structures that you have a 
> "string_to_c()" helper function for that. That may be "good abstraction", 
> but it's totally idiotic, because it results in horrible source code!
> 
> Tell me which is more readable:
> 
> 	printf("Hello %s\n", sb->buf);
> 
> or
> 
> 	printf("Hello %s\n", strbuf_to_c(sb));

Point taken although no sane person would name it strbuf_to_c(...).

	Sam

  reply	other threads:[~2007-10-05 17:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wsu2sad0.fsf@gollum.intra.norang.ca>
2007-10-05  8:20 ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Pierre Habouzit
2007-10-05  8:11   ` [AGGREGATED PATCH] Fix in-place editing functions in convert.c Pierre Habouzit
2007-10-05  9:24     ` Johannes Sixt
2007-10-05 13:07     ` Bernt Hansen
2007-10-05 15:26     ` Linus Torvalds
2007-10-05 15:50       ` Pierre Habouzit
2007-10-05 16:21       ` Sam Ravnborg
2007-10-05 16:35         ` Pierre Habouzit
2007-10-05 17:25           ` Sam Ravnborg
2007-10-05 16:43         ` Linus Torvalds
2007-10-05 17:24           ` Sam Ravnborg [this message]
2007-10-05 18:05             ` Linus Torvalds
2007-10-05 19:27               ` Dmitry Potapov
2007-10-05 19:33                 ` Linus Torvalds
2007-10-05  8:27   ` [PATCH] Fix memory leak in apply_filter Pierre Habouzit
2007-10-05  8:29   ` Pierre Habouzit
2007-10-05  8:30   ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Johannes Schindelin
2007-10-05  8:40     ` Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071005172425.GD31413@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=bernt@alumni.uwaterloo.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).