git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Lichtenheld <frank@lichtenheld.de>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Theodore Ts'o <tytso@mit.edu>, git@vger.kernel.org
Subject: Re: [PATCH] mergetool: support absolute paths to tools by git config merge.<tool>path
Date: Tue, 9 Oct 2007 00:00:25 +0200	[thread overview]
Message-ID: <20071008220025.GZ31659@planck.djpig.de> (raw)
In-Reply-To: <11918785613855-git-send-email-prohaska@zib.de>

On Mon, Oct 08, 2007 at 11:22:40PM +0200, Steffen Prohaska wrote:
> This commit adds a mechanism to provide absolute paths to the
> commands called by 'git mergetool'. A path can be specified
> in the configuation variable merge.<toolname>path.

Why not merge.<toolname>.path?
This would it make easy to introduce new variables of the form
merge.<toolname>.<var> later if needed. I also think it is more
consistent with names of existing configuration variables.
(think branch.<name>.<var> or remote.<name>.<var>)

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/

  parent reply	other threads:[~2007-10-08 22:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 21:22 [PATCH] mergetool: support absolute paths to tools by git config merge.<tool>path Steffen Prohaska
2007-10-08 21:22 ` [PATCH] mergetool: add support for ECMerge Steffen Prohaska
2007-10-08 21:44   ` Theodore Tso
2007-10-09  6:14     ` Steffen Prohaska
2007-10-09 12:37       ` Johannes Schindelin
2007-10-09 12:49         ` Steffen Prohaska
2007-10-09 13:03         ` Alan Hadsell
2007-10-09 13:17           ` Steffen Prohaska
2007-10-09 14:21             ` Alan Hadsell
2007-10-08 21:57 ` [PATCH] mergetool: support absolute paths to tools by git config merge.<tool>path Theodore Tso
2007-10-08 22:01   ` Theodore Tso
2007-10-09  6:30   ` Steffen Prohaska
2007-10-08 22:00 ` Frank Lichtenheld [this message]
2007-10-09  6:42   ` Steffen Prohaska
2007-10-09 12:35 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071008220025.GZ31659@planck.djpig.de \
    --to=frank@lichtenheld.de \
    --cc=git@vger.kernel.org \
    --cc=prohaska@zib.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).