From: Jonas Fonseca <fonseca@diku.dk>
To: James Bowes <jbowes@dangerouslyinc.com>
Cc: git@vger.kernel.org
Subject: Re: [TIG PATCH] Add missing = for comparison in obsolete actions check.
Date: Tue, 9 Oct 2007 02:53:36 +0200 [thread overview]
Message-ID: <20071009005336.GA30818@diku.dk> (raw)
In-Reply-To: <20071008173034.GA27292@crux.toronto.redhat.com>
James Bowes <jbowes@dangerouslyinc.com> wrote Mon, Oct 08, 2007:
> Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
> ---
> tig.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tig.c b/tig.c
> index 933d083..30c505b 100644
> --- a/tig.c
> +++ b/tig.c
> @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])
> }
>
> request = get_request(argv[2]);
> - if (request = REQ_NONE) {
> + if (request == REQ_NONE) {
> const char *obsolete[] = { "cherry-pick" };
> size_t namelen = strlen(argv[2]);
> int i;
Oops, thanks. I should readd -Wall to CFLAGS in my config.make file.
--
Jonas Fonseca
prev parent reply other threads:[~2007-10-09 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 17:30 [TIG PATCH] Add missing = for comparison in obsolete actions check James Bowes
2007-10-09 0:53 ` Jonas Fonseca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009005336.GA30818@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=jbowes@dangerouslyinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).