git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: "Väinö Järvelä" <v@pp.inet.fi>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.
Date: Tue, 9 Oct 2007 20:20:43 +0200	[thread overview]
Message-ID: <20071009182043.GA2997@steel.home> (raw)
In-Reply-To: <81553116-3A4F-4526-A772-9A43C53D3E22@pp.inet.fi>

Väinö Järvelä, Tue, Oct 09, 2007 12:52:01 +0200:
> Hi,
> 
> These patches should have been numbered, sorry, The test patch was  
> supposed be number 1 of 2.
> 
> The patches were done on top of next. The fix should be checked, as  
> it's mostly a quick fix to get it to work, probably not the correct  
> way to fix that bug, or is it?

Your test does not crash on my system and your fix is obviously bogus.
Just take a look at the only call site of the tail_link_ref: ret
cannot be NULL. alloc_ref will crash in memset, if this were the case.

If you can reproduce the crash reliably, try compiling git with -g and
run it in your test with valgrind or gdb (assuming these are available
to you).

  reply	other threads:[~2007-10-09 18:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09  8:51 [PATCH] Added a test for fetching remote tags when there is not tags Väinö Järvelä
2007-10-09  8:51 ` [PATCH] Fixed crash in " Väinö Järvelä
2007-10-09 10:52   ` Väinö Järvelä
2007-10-09 18:20     ` Alex Riesen [this message]
2007-10-10  5:10       ` Jeff King
2007-10-10 21:27         ` Alex Riesen
2007-10-10 21:33           ` Jeff King
2007-10-12  4:07           ` Shawn O. Pearce
2007-10-12 20:40             ` [PATCH] Fix a crash in ls-remote when refspec expands into nothing Alex Riesen
2007-10-14 21:26               ` Lars Hjemli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071009182043.GA2997@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=v@pp.inet.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).