From: Jeff King <peff@peff.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "Väinö Järvelä" <v@pp.inet.fi>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.
Date: Wed, 10 Oct 2007 01:10:35 -0400 [thread overview]
Message-ID: <20071010051034.GA30834@coredump.intra.peff.net> (raw)
In-Reply-To: <20071009182043.GA2997@steel.home>
On Tue, Oct 09, 2007 at 08:20:43PM +0200, Alex Riesen wrote:
> Your test does not crash on my system and your fix is obviously bogus.
> Just take a look at the only call site of the tail_link_ref: ret
> cannot be NULL. alloc_ref will crash in memset, if this were the case.
His work is almost certainly on top of next, which crashes reliably with
the test and has an additional call site for tail_link_ref. Aside from
some trailing whitespace in the patch, I think his fix is reasonable.
-Peff
next prev parent reply other threads:[~2007-10-10 5:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 8:51 [PATCH] Added a test for fetching remote tags when there is not tags Väinö Järvelä
2007-10-09 8:51 ` [PATCH] Fixed crash in " Väinö Järvelä
2007-10-09 10:52 ` Väinö Järvelä
2007-10-09 18:20 ` Alex Riesen
2007-10-10 5:10 ` Jeff King [this message]
2007-10-10 21:27 ` Alex Riesen
2007-10-10 21:33 ` Jeff King
2007-10-12 4:07 ` Shawn O. Pearce
2007-10-12 20:40 ` [PATCH] Fix a crash in ls-remote when refspec expands into nothing Alex Riesen
2007-10-14 21:26 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010051034.GA30834@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
--cc=v@pp.inet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).