From: Frank Lichtenheld <frank@lichtenheld.de>
To: Jan Wielemaker <jan@swi-prolog.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-cvsserver: added support for update -p
Date: Wed, 10 Oct 2007 22:00:30 +0200 [thread overview]
Message-ID: <20071010200029.GK31659@planck.djpig.de> (raw)
In-Reply-To: <200710101316.03633.jan@swi-prolog.org>
On Wed, Oct 10, 2007 at 01:16:03PM +0200, Jan Wielemaker wrote:
> + # if we have a -p we should just send the file
> + if ( exists ( $state->{opt}{p} ) )
> + {
> + if ( open my $fh, '-|', "git-cat-file", "blob", $meta->{filehash} )
> + { while ( <$fh> )
> + { print "M " . $_;
> + }
> + close $fh or die ("Couldn't close filehandle for transmitfile(): $!");
> + } else
> + { die("Couldn't execute git-cat-file");
> + }
> +
> + next;
> + }
There seems to be inconsistent whitespace in the patch.
And please never do that else\n{ again, it hurts my eye ;)
Will try to test (and write a testcase for) it tomorrow.
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2007-10-10 20:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 11:16 [PATCH] git-cvsserver: added support for update -p Jan Wielemaker
2007-10-10 13:47 ` Johannes Schindelin
2007-10-10 14:26 ` Jan Wielemaker
2007-10-10 16:41 ` Johannes Schindelin
2007-10-10 17:27 ` Jan Wielemaker
2007-10-10 19:27 ` Johannes Schindelin
2007-10-10 20:00 ` Frank Lichtenheld [this message]
2007-10-11 8:45 ` Andreas Ericsson
2007-10-11 16:36 ` [PATCH] cvsserver: " Frank Lichtenheld
2007-10-11 16:52 ` Jan Wielemaker
2007-10-11 17:29 ` Frank Lichtenheld
2007-10-11 20:59 ` Johannes Schindelin
2007-10-11 21:07 ` Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010200029.GK31659@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=jan@swi-prolog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).