From: Frank Lichtenheld <frank@lichtenheld.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <junkio@cox.net>,
Jan Wielemaker <jan@swi-prolog.org>
Subject: Re: [PATCH] cvsserver: added support for update -p
Date: Thu, 11 Oct 2007 23:07:37 +0200 [thread overview]
Message-ID: <20071011210737.GP31659@planck.djpig.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0710112158330.4174@racer.site>
On Thu, Oct 11, 2007 at 09:59:28PM +0100, Johannes Schindelin wrote:
> On Thu, 11 Oct 2007, Frank Lichtenheld wrote:
>
> > + if ( exists ( $state->{opt}{p} ) )
>
> I see you kept the coding style, which is not in agreement with the rest
> of git... Intention or oversight?
It is in agreement with the rest of git-cvsserver. I really like the
style of the other perl stuff in git better, but I wasn't sure what
style takes precedence...
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
prev parent reply other threads:[~2007-10-11 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 11:16 [PATCH] git-cvsserver: added support for update -p Jan Wielemaker
2007-10-10 13:47 ` Johannes Schindelin
2007-10-10 14:26 ` Jan Wielemaker
2007-10-10 16:41 ` Johannes Schindelin
2007-10-10 17:27 ` Jan Wielemaker
2007-10-10 19:27 ` Johannes Schindelin
2007-10-10 20:00 ` Frank Lichtenheld
2007-10-11 8:45 ` Andreas Ericsson
2007-10-11 16:36 ` [PATCH] cvsserver: " Frank Lichtenheld
2007-10-11 16:52 ` Jan Wielemaker
2007-10-11 17:29 ` Frank Lichtenheld
2007-10-11 20:59 ` Johannes Schindelin
2007-10-11 21:07 ` Frank Lichtenheld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011210737.GP31659@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jan@swi-prolog.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).