git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Shun Kei Leung <kevinlsk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-fast-import crashes
Date: Fri, 12 Oct 2007 23:29:16 -0400	[thread overview]
Message-ID: <20071013032916.GL27899@spearce.org> (raw)
In-Reply-To: <e66701d40710120242p6fc05148hd40d19d295373ac4@mail.gmail.com>

Shun Kei Leung <kevinlsk@gmail.com> wrote:
> Program received signal EXC_BAD_ACCESS, Could not access memory.
> Reason: KERN_INVALID_ADDRESS at address: 0x64617469
> in_window (win=0x5004d0, offset=3501) at sha1_file.c:701
> 701             off_t win_off = win->offset;
...
> (gdb) print win
> $1 = (struct pack_window *) 0x5004d0
> (gdb) print *win
> $2 = {
>   next = 0x64617461,
>   base = 0x20333936 <Address 0x20333936 out of bounds>,
>   offset = 22523564414626158,
>   len = 1685026675,
>   last_used = 795894075,
>   inuse_cnt = 0
> }

Wow.  There's no way that struct pack_window is valid anymore.
The base isn't a valid address.  The offset cannot possibly be
correct (you don't have that big of a packfile, do you?!

What does `git count-objects -v` give you?  I'm specifically
interested in how many packfiles you have.  The other thing that
may be interesting to see is the value of pack_open_windows and
peak_pack_open_windows (file scope in sha1_file.c).

Then again, maybe that isn't interesting.  This looks like it is
memory corruption (e.g. someone overwriting a free'd segment),
but that sort of memory corruption is very hard to track down.

-- 
Shawn.

  reply	other threads:[~2007-10-13  3:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  9:42 git-fast-import crashes Shun Kei Leung
2007-10-13  3:29 ` Shawn O. Pearce [this message]
2007-10-13  3:34   ` Shawn O. Pearce
2007-10-13  7:36     ` Pierre Habouzit
2007-10-13  7:50       ` Pierre Habouzit
2007-10-15  4:53         ` Shun Kei Leung
2007-10-15  7:33           ` Pierre Habouzit
2007-10-15  8:19             ` Shun Kei Leung
2007-10-16  7:13               ` Shun Kei Leung
2007-10-16  7:46                 ` Pierre Habouzit
2007-10-16  8:01                   ` Shun Kei Leung
2007-10-16  8:04                     ` Pierre Habouzit
2007-10-13 12:58   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071013032916.GL27899@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=kevinlsk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).