From: Pierre Habouzit <madcoder@debian.org>
To: "Shawn O. Pearce" <spearce@spearce.org>,
Shun Kei Leung <kevinlsk@gmail.com>,
git@vger.kernel.org
Subject: Re: git-fast-import crashes
Date: Sat, 13 Oct 2007 09:50:27 +0200 [thread overview]
Message-ID: <20071013075027.GD7110@artemis.corp> (raw)
In-Reply-To: <20071013073640.GC7110@artemis.corp>
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
On sam, oct 13, 2007 at 07:36:40 +0000, Pierre Habouzit wrote:
> On Sat, Oct 13, 2007 at 03:34:07AM +0000, Shawn O. Pearce wrote:
> > "Shawn O. Pearce" <spearce@spearce.org> wrote:
> > > Shun Kei Leung <kevinlsk@gmail.com> wrote:
> > > > I am using git 1.5.3.4.206.g58ba4-dirty on Mac OS X 10.4.
> > ....
> > > > Program received signal EXC_BAD_ACCESS, Could not access memory.
> > > > Reason: KERN_INVALID_ADDRESS at address: 0x64617469
> > ....
> > > This looks like it is
> > > memory corruption (e.g. someone overwriting a free'd segment),
> > > but that sort of memory corruption is very hard to track down.
> >
> > OK, so the version you have (58ba4) is the latest fast-import after
> > the strbuf.c series went in. The one immediately before that series
> > was 4bf538 and is probably actually stable.
> >
> > So I wonder, can you test 4bf538 and then if it is good bisect
> > between those two commits? There must be a memory corruption
> > introduced by one of the strbuf changes...
>
> Gasp, if you get the offending sha1 commit, don't forget to Cc: me.
Okay, given that fast-import uses quote_c_style, I believe this is the
same but that the one that was reported already. I've read the full
`git diff 4bf53833dbca666f61b5177977e96d453527db20.. -- fast-import.c`
and nothing alarming shows up.
Please try to apply:
http://git.madism.org/?p=git.git;a=commit;h=7406e83342cd445ac38c1753c5fce75377737e2f
And see if that fixes the issue for you. Else a bisection would be
much appreciated. Thanks.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-13 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 9:42 git-fast-import crashes Shun Kei Leung
2007-10-13 3:29 ` Shawn O. Pearce
2007-10-13 3:34 ` Shawn O. Pearce
2007-10-13 7:36 ` Pierre Habouzit
2007-10-13 7:50 ` Pierre Habouzit [this message]
2007-10-15 4:53 ` Shun Kei Leung
2007-10-15 7:33 ` Pierre Habouzit
2007-10-15 8:19 ` Shun Kei Leung
2007-10-16 7:13 ` Shun Kei Leung
2007-10-16 7:46 ` Pierre Habouzit
2007-10-16 8:01 ` Shun Kei Leung
2007-10-16 8:04 ` Pierre Habouzit
2007-10-13 12:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071013075027.GD7110@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=kevinlsk@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).