git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Habouzit <madcoder@debian.org>
To: Shun Kei Leung <kevinlsk@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: git-fast-import crashes
Date: Mon, 15 Oct 2007 09:33:07 +0200	[thread overview]
Message-ID: <20071015073307.GA1508@artemis.corp> (raw)
In-Reply-To: <e66701d40710142153o70a7b696r928491be437ac6d@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Mon, Oct 15, 2007 at 04:53:38AM +0000, Shun Kei Leung wrote:
> Hi,
> 
> Sorry for the late reply. I was away from my computer in the weekend.
> 
> 
> Hi Pierre,
> 
> I didn't try:
> http://git.madism.org/?p=git.git;a=commit;h=7406e83342cd445ac38c1753c5fce75377737e2f
> 
> because the bad commit turns out to be b449f4c according to `git bisect'.

  I don't get the reason for your "because" but so be it. The commit you
show is not obviously broken to me, especially not in fast-import.c, so
I'll need more input.  Could you please run your test in valgrind and
report the output please? Or if the data to reproduce the bug are online
or shareable, it'd be great to share, so that I can reproduce the issue
here.


-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-10-15  7:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  9:42 git-fast-import crashes Shun Kei Leung
2007-10-13  3:29 ` Shawn O. Pearce
2007-10-13  3:34   ` Shawn O. Pearce
2007-10-13  7:36     ` Pierre Habouzit
2007-10-13  7:50       ` Pierre Habouzit
2007-10-15  4:53         ` Shun Kei Leung
2007-10-15  7:33           ` Pierre Habouzit [this message]
2007-10-15  8:19             ` Shun Kei Leung
2007-10-16  7:13               ` Shun Kei Leung
2007-10-16  7:46                 ` Pierre Habouzit
2007-10-16  8:01                   ` Shun Kei Leung
2007-10-16  8:04                     ` Pierre Habouzit
2007-10-13 12:58   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015073307.GA1508@artemis.corp \
    --to=madcoder@debian.org \
    --cc=git@vger.kernel.org \
    --cc=kevinlsk@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).