From: Christian Couder <chriscool@tuxfamily.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 6/7] Bisect: factorise "bisect_{bad,good,dunno}" into "bisect_state".
Date: Tue, 16 Oct 2007 08:28:04 +0200 [thread overview]
Message-ID: <200710160828.05137.chriscool@tuxfamily.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710151338000.25221@racer.site>
Hi Dscho,
Le lundi 15 octobre 2007, Johannes Schindelin a écrit :
> Hi,
>
> On Mon, 15 Oct 2007, Christian Couder wrote:
> >
> > But the new "bisect_state" takes one more argument, because the first
> > one must be "good" "bad" or "dunno".
> >
> > So when there is only one argument HEAD is used, and when there are 2
> > arguments, $2 is used as the good|bad|dunno rev.
>
> Ah, that explains it! But do you not need to do "2,bad|2,good|2,dunno"
> in that case? Or even better: "2,*"?
Perhaps it would be an improvement at least in speed for "2,good"
or "2,dunno".
I wanted to keep exactly the same processing as there was before, in case
something like "git bisect good v1.5.3.3..v1.5.3.4" was supported. But it
seems it doesn't work. I don't know if it's a bug or a feature.
Christian.
next prev parent reply other threads:[~2007-10-16 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 12:30 [PATCH 6/7] Bisect: factorise "bisect_{bad,good,dunno}" into "bisect_state" Christian Couder
2007-10-14 16:15 ` Johannes Schindelin
2007-10-15 3:42 ` Christian Couder
2007-10-15 12:38 ` Johannes Schindelin
2007-10-16 6:28 ` Christian Couder [this message]
2007-10-16 11:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710160828.05137.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).