git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eygene Ryabinkin <rea-git@codelabs.ru>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-svn: use "no warnings 'once'" to disable false-positives
Date: Tue, 16 Oct 2007 20:50:25 +0400	[thread overview]
Message-ID: <20071016165025.GT984@void.codelabs.ru> (raw)
In-Reply-To: <20071016074318.GA32348@soma>

Eric, good day.

Tue, Oct 16, 2007 at 12:43:18AM -0700, Eric Wong wrote:
> Thanks, minor nit regarding fixed in the patch below.
> 
> 	"{ no warnings 'once';"
> 
> on the same line as the "{"

Yes, I did this intentionally to signify that this block is used
just for the pragma.  But I felt that it is against the style, so
you're right.

Thank you!
-- 
Eygene

      reply	other threads:[~2007-10-16 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15  7:19 [PATCH] git-svn: use "no warnings 'once'" to disable false-positives Eygene Ryabinkin
2007-10-16  7:43 ` Eric Wong
2007-10-16 16:50   ` Eygene Ryabinkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071016165025.GT984@void.codelabs.ru \
    --to=rea-git@codelabs.ru \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).