* [PATCH] cvsexportcommit: get rid of temporary directory
@ 2007-10-15 22:32 Johannes Schindelin
2007-10-16 21:22 ` Robin Rosenberg
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin @ 2007-10-15 22:32 UTC (permalink / raw)
To: git, hjemli, gitster
Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use
a temporary directory in cvsexportcommit. So there is no need to set
one up.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
git-cvsexportcommit.perl | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index a33fa8d..6b0123c 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -30,11 +30,6 @@ if ($opt_d) {
@cvs = ('cvs');
}
-# setup a tempdir
-our ($tmpdir, $tmpdirname) = tempdir('git-cvsapplycommit-XXXXXX',
- TMPDIR => 1,
- CLEANUP => 1);
-
# resolve target commit
my $commit;
$commit = pop @ARGV;
--
1.5.3.4.1174.gcd0d6-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cvsexportcommit: get rid of temporary directory
2007-10-15 22:32 [PATCH] cvsexportcommit: get rid of temporary directory Johannes Schindelin
@ 2007-10-16 21:22 ` Robin Rosenberg
0 siblings, 0 replies; 2+ messages in thread
From: Robin Rosenberg @ 2007-10-16 21:22 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, hjemli, gitster
tisdag 16 oktober 2007 skrev Johannes Schindelin:
>
> Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use
> a temporary directory in cvsexportcommit. So there is no need to set
> one up.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked
Discovered because Wingit made a lot of noise about $tmpdir being used only
once.
-- robin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-16 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 22:32 [PATCH] cvsexportcommit: get rid of temporary directory Johannes Schindelin
2007-10-16 21:22 ` Robin Rosenberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).