From: Frank Lichtenheld <frank@lichtenheld.de>
To: Morten Welinder <mwelinder@gmail.com>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] Use exit 1 instead of die when req_Root fails.
Date: Wed, 17 Oct 2007 21:08:23 +0200 [thread overview]
Message-ID: <20071017190822.GD9041@planck.djpig.de> (raw)
In-Reply-To: <118833cc0710170739i179e7389k1e44f70086ca88be@mail.gmail.com>
On Wed, Oct 17, 2007 at 10:39:52AM -0400, Morten Welinder wrote:
> > made it into your repo. It fixes test failures on my machine that have
> > been plauging me for months.
>
> That sounds more like a reason to fix the test. "die" is the perl
> standard way of
> reporting an error. It will print the error message on stderr, not on
> stdout like
> your version does.
Please note that git-cvsserver is special in that its output will never
be displayed directly to the user but is always interpreted first by
the client. So print "E something" is acutally in some cases more
correct than print STDERR something.
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2007-10-17 19:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 14:05 [PATCH] Use exit 1 instead of die when req_Root fails Brian Gernhardt
2007-10-17 14:39 ` Morten Welinder
2007-10-17 15:16 ` Brian Gernhardt
2007-10-17 15:39 ` Lars Hjemli
2007-10-17 18:40 ` Brian Gernhardt
2007-10-17 19:27 ` Lars Hjemli
2007-10-18 18:54 ` Jan Hudec
2007-10-17 19:08 ` Frank Lichtenheld [this message]
2007-10-17 19:06 ` Frank Lichtenheld
2007-10-17 19:15 ` Brian Gernhardt
2007-10-18 5:04 ` Shawn O. Pearce
2007-10-18 13:33 ` Frank Lichtenheld
-- strict thread matches above, loose matches on Subject: below --
2007-10-04 1:19 git-cvsserver test failures (still) Frank Lichtenheld
2007-10-04 1:43 ` [PATCH] Use exit 1 instead of die when req_Root fails Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017190822.GD9041@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=mwelinder@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).