git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'
Date: Thu, 18 Oct 2007 23:45:01 -0400	[thread overview]
Message-ID: <20071019034501.GG14735@spearce.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710182328580.19446@xanadu.home>

Nicolas Pitre <nico@cam.org> wrote:
> On Thu, 18 Oct 2007, Shawn O. Pearce wrote:
> > Yup.  Your patches were a big improvement.  But I'm now sitting here
> > wondering if we shouldn't just allow a progress meter to overwrite
> > the prior one.  Then you only see the current task and progress,
> > or the final output if we have nothing further to say about that.
> 
> And then you've lost some diagnostic clue (the absolute numbers) about 
> the actual number of objects that were listed for "deltification" for 
> example.

Leave the "Total" line.  Add to it the number of objects we had to
consider for deltification as part of the packing.
 
> And imagine that you see the progress moving slowly because the remote 
> server is a NSLU2, but it says 80%.  Then you go for a coffee and the 
> progress says 20% when you return because it now has moved to a 
> different phase.  Rather counter intuitive.

Yea, I didn't consider that.  That's where you need to show the
number of steps and which one you are on, so the meter looks
more like:

	Step 1/3: Counting objects: .... \r
	Step 2/4: Compressing objects: ... \r
	Step 3/3: Writing objects: .... \r

only all smashed into one line of course, so only the most recent
one is being displayed.

-- 
Shawn.

  parent reply	other threads:[~2007-10-19  3:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19  0:45 [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Shawn O. Pearce
2007-10-19  2:12 ` Jeff King
2007-10-19  2:19   ` Sam Vilain
2007-10-19  2:24     ` David Symonds
2007-10-19  2:34       ` Shawn O. Pearce
2007-10-19  3:02         ` Nicolas Pitre
2007-10-19  2:36       ` Jeff King
2007-10-19  2:55         ` Sam Vilain
2007-10-19  2:25     ` Jeff King
2007-10-19  2:21   ` Shawn O. Pearce
2007-10-19  2:34     ` Jeff King
2007-10-19  2:47       ` Shawn O. Pearce
2007-10-19  3:01       ` Nicolas Pitre
2007-10-19  3:07         ` Jeff King
2007-10-19  3:24           ` Nicolas Pitre
2007-10-19  3:32             ` Jeff King
2007-10-19  3:50               ` Nicolas Pitre
2007-10-19  3:56                 ` Jeff King
2007-10-19  4:21                   ` Linus Torvalds
2007-10-19  4:29                     ` Jeff King
2007-10-19 11:58                       ` Nicolas Pitre
2007-10-19 19:00                         ` Linus Torvalds
2007-10-19 21:57                           ` Linus Torvalds
2007-10-19  5:09                 ` Shawn O. Pearce
2007-10-19  3:33             ` Shawn O. Pearce
2007-10-19  5:03         ` [PATCH] Stop displaying "Pack pack-$ID created." during git-gc Shawn O. Pearce
2007-10-19  2:49     ` [PATCH] Change 'Deltifying objects' to 'Delta compressing objects' Nicolas Pitre
2007-10-19  3:17       ` Shawn O. Pearce
2007-10-19  3:38         ` Nicolas Pitre
2007-10-19  3:41           ` Jeff King
2007-10-19  3:45           ` Shawn O. Pearce [this message]
2007-10-19  4:02             ` Nicolas Pitre
2007-10-19 11:44             ` Wincent Colaiuta
2007-10-19  2:45   ` Nicolas Pitre
2007-10-19  2:59     ` Jeff King
2007-10-19  3:11       ` Nicolas Pitre
2007-10-19  3:15         ` Jeff King
2007-10-19  3:27           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071019034501.GG14735@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).