From: "Shawn O. Pearce" <spearce@spearce.org>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: gitk patch collection pull request
Date: Fri, 19 Oct 2007 23:10:48 -0400 [thread overview]
Message-ID: <20071020031048.GQ14735@spearce.org> (raw)
In-Reply-To: <18200.36704.936554.220173@cargo.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> wrote:
> Shawn O. Pearce writes:
> > The following changes since commit 719c2b9d926bf2be4879015e3620d27d32f007b6:
> > Paul Mackerras (1):
> > gitk: Fix bug causing undefined variable error when cherry-picking
> >
> > are available in the git repository at:
> >
> > git://repo.or.cz:/git/spearce.git gitk
...
> > Jonathan del Strother (2):
> > gitk: Added support for OS X mouse wheel
> > Fixing gitk indentation
>
> This one is bogus. Firstly, it doesn't have "gitk:" at the start of
> the headline (and "Fixing" should be "Fix"). Secondly, the actual
> change itself is bogus. It changes an initial tab to 8 spaces on each
> of 4 lines. I like it the way it is - and if he wanted to change it,
> he should have changed it throughout the file, not just on 4 lines.
> So that change is rejected.
>
> The other changes are OK. If you could re-do your tree without
> 0d6df4de (and possible change "Added" to "Add" in e1b5683c while
> you're at it), I'll do the pull.
Done. I also added this one from Michele:
From: Michele Ballabio <barra_cuda@katamail.com>
Subject: [PATCH-resent] gitk: fix in procedure drawcommits
--
Shawn.
next prev parent reply other threads:[~2007-10-20 3:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 5:28 gitk patch collection pull request Shawn O. Pearce
2007-10-19 7:25 ` [PATCH resend again] gitk: Do not pick up file names of "copy from" lines Johannes Sixt
2007-10-19 7:32 ` Shawn O. Pearce
2007-10-19 8:05 ` Johannes Sixt
2007-10-19 8:14 ` Shawn O. Pearce
2007-10-19 11:05 ` gitk patch collection pull request Paul Mackerras
2007-10-20 3:10 ` Shawn O. Pearce [this message]
2007-10-20 11:12 ` Jonathan del Strother
2007-10-20 11:46 ` Paul Mackerras
2007-10-20 13:00 ` Jonathan del Strother
2007-10-20 15:32 ` Jan Hudec
2007-10-19 13:44 ` [PATCH-resent] gitk: fix in procedure drawcommits Michele Ballabio
2007-10-20 10:16 ` Paul Mackerras
2007-10-20 16:02 ` Michele Ballabio
2007-10-20 18:35 ` Jan Hudec
2007-10-21 3:01 ` Paul Mackerras
2007-10-21 12:12 ` Rocco Rutte
2007-10-19 19:31 ` gitk patch collection pull request Linus Torvalds
2007-10-20 4:45 ` Paul Mackerras
2007-10-20 4:51 ` Linus Torvalds
2007-10-23 0:20 ` Paul Mackerras
2007-10-23 19:17 ` Linus Torvalds
2007-10-23 23:37 ` Paul Mackerras
2007-10-23 23:51 ` Linus Torvalds
2007-10-24 0:17 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020031048.GQ14735@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).