From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Dan McGee <dan@archlinux.org>, git@vger.kernel.org
Subject: Re: [PATCH] send-pack: respect '+' on wildcard refspecs
Date: Sat, 20 Oct 2007 00:57:33 -0400 [thread overview]
Message-ID: <20071020045733.GS14735@spearce.org> (raw)
In-Reply-To: <20071020042257.GA26755@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Fri, Oct 19, 2007 at 08:00:37PM -0500, Dan McGee wrote:
>
> > Turns out I didn't have GIT_EXEC_PATH set up right. Once I do that,
> > everything seems to work just fine.
> >
> > Thanks for looking into this Jeff, and git-bisect just won me over. It
> > made easy work of finding the commit that broke this.
>
> Huzzah, success! Shawn, this should probably go on 'maint'. Although it
> is probably not high priority (it has been broken since May; I think
> wildcard push refspecs must not be that common), it is a fairly trivial
> fix that shouldn't impact anyone else.
Yea, its already queued on maint. Both the patch and the
tests are obviously correct. Its broken without the patch.
Its documented/expected behavior fixed by the patch. IMHO it
belongs in maint.
--
Shawn.
prev parent reply other threads:[~2007-10-20 4:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 9:04 [PATCH] send-pack: respect '+' on wildcard refspecs Jeff King
2007-10-19 9:04 ` Jeff King
2007-10-19 12:10 ` Dan McGee
2007-10-19 12:27 ` Jeff King
2007-10-19 13:38 ` Dan McGee
2007-10-19 13:43 ` Jeff King
2007-10-19 14:11 ` Dan McGee
2007-10-20 1:00 ` Dan McGee
2007-10-20 4:22 ` Jeff King
2007-10-20 4:57 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020045733.GS14735@spearce.org \
--to=spearce@spearce.org \
--cc=dan@archlinux.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).