From: Scott Parish <srp@srparish.net>
To: git@vger.kernel.org
Subject: [PATCH] When exec'ing sub-commands, fall back on execvp (the PATH)
Date: Fri, 19 Oct 2007 23:44:59 -0700 [thread overview]
Message-ID: <20071020064459.GB2237@srparish.net> (raw)
Signed-off-by: Scott R Parish <srp@srparish.net>
---
exec_cmd.c | 26 ++++++++++++++++++++++----
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/exec_cmd.c b/exec_cmd.c
index 9b74ed2..674c9f3 100644
--- a/exec_cmd.c
+++ b/exec_cmd.c
@@ -34,15 +34,15 @@ int execv_git_cmd(const char **argv)
{
char git_command[PATH_MAX + 1];
int i;
+ int rc;
const char *paths[] = { current_exec_path,
getenv(EXEC_PATH_ENVIRONMENT),
builtin_exec_path };
+ const char *tmp;
+ size_t len;
for (i = 0; i < ARRAY_SIZE(paths); ++i) {
- size_t len;
- int rc;
const char *exec_dir = paths[i];
- const char *tmp;
if (!exec_dir || !*exec_dir) continue;
@@ -106,8 +106,26 @@ int execv_git_cmd(const char **argv)
argv[0] = tmp;
}
- return -1;
+ rc = snprintf(git_command, sizeof(git_command), "git-%s", argv[0]);
+ if (rc < 0 || rc >= sizeof(git_command) - len) {
+ fprintf(stderr, "git: command name given is too long.\n");
+ return -1;
+ }
+
+ tmp = argv[0];
+ argv[0] = git_command;
+
+ trace_argv_printf(argv, -1, "trace: exec:");
+
+ /* execve() can only ever return if it fails */
+ execvp(git_command, (char **)argv);
+
+ trace_printf("trace: exec failed: %s\n", strerror(errno));
+
+ argv[0] = tmp;
+
+ return -1;
}
--
1.5.3.GIT
next reply other threads:[~2007-10-20 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 6:44 Scott Parish [this message]
2007-10-20 7:30 ` [PATCH] When exec'ing sub-commands, fall back on execvp (the PATH) Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020064459.GB2237@srparish.net \
--to=srp@srparish.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox