From: Scott R Parish <srp@srparish.net>
To: git@vger.kernel.org
Subject: [PATCH] If git is ran with a relative path, try building an absolute exec_path from it
Date: Fri, 19 Oct 2007 23:46:17 -0700 [thread overview]
Message-ID: <20071020064617.GC2237@srparish.net> (raw)
Signed-off-by: Scott R Parish <srp@srparish.net>
---
git.c | 35 +++++++++++++++++++++++++++++++++--
1 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/git.c b/git.c
index 9eaca1d..d129ecc 100644
--- a/git.c
+++ b/git.c
@@ -28,6 +28,35 @@ static void prepend_to_path(const char *dir, int len)
free(path);
}
+static char *rel_to_abs_exec_path(const char *cmd) {
+ int len, rc;
+ char *exec_path = xmalloc(PATH_MAX + 1);
+
+ if (!getcwd(exec_path, PATH_MAX)) {
+ fprintf(stderr, "git: cannot determine current directory: %s\n",
+ strerror(errno));
+ free(exec_path);
+ return NULL;
+ }
+ len = strlen(exec_path);
+
+ /* Trivial cleanup */
+ while (!prefixcmp(cmd, "./")) {
+ cmd += 2;
+ while (*cmd == '/')
+ cmd++;
+ }
+
+ rc = snprintf(exec_path + len, PATH_MAX - len, "/%s", cmd);
+ if (rc < 0 || rc >= PATH_MAX - len) {
+ fprintf(stderr, "git: command name given is too long.\n");
+ free(exec_path);
+ return NULL;
+ }
+
+ return exec_path;
+}
+
static int handle_options(const char*** argv, int* argc, int* envchanged)
{
int handled = 0;
@@ -409,13 +438,15 @@ int main(int argc, const char **argv)
/*
* Take the basename of argv[0] as the command
* name, and the dirname as the default exec_path
- * if it's an absolute path and we don't have
- * anything better.
+ * if we don't have anything better.
*/
if (slash) {
*slash++ = 0;
if (*cmd == '/')
exec_path = cmd;
+ else
+ exec_path = rel_to_abs_exec_path(cmd);
+
cmd = slash;
}
--
1.5.3.GIT
next reply other threads:[~2007-10-20 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 6:46 Scott R Parish [this message]
2007-10-20 7:21 ` [PATCH] Deduce exec_path also from calls to git with a relative path Johannes Schindelin
2007-10-20 12:25 ` David Brown
2007-10-20 21:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020064617.GC2237@srparish.net \
--to=srp@srparish.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).