From: Alex Riesen <raa.lkml@gmail.com>
To: Scott Parish <sRp@srparish.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH trailing ws fixed] use only the PATH for exec'ing git commands
Date: Tue, 23 Oct 2007 23:12:02 +0200 [thread overview]
Message-ID: <20071023211202.GA729@steel.home> (raw)
In-Reply-To: <20071023040844.GQ16291@srparish.net>
Scott Parish, Tue, Oct 23, 2007 06:08:45 +0200:
> We need to correctly set up PATH for non-c based git commands. Since we
> already do this, we can just use that PATH and execvp, instead of looping
> over the paths with execve.
>
> This patch adds a setup_path() function to exec_cmd.c, which sets
> the PATH order correctly for our search order. execv_git_cmd() is
> stripped down to setting up argv and calling execvp(). git.c's main()
> only only needs to call setup_path().
>
> Signed-off-by: Scott R Parish <srp@srparish.net>
Acked-by: Alex Riesen <raa.lkml@gmail.com>
Don't forget to mention it needs the patch from Johannes re "deducing
exec_path from calls to git with a relative path" and your
"current_exec_path"-patch. Took me a while to figure these out...
next prev parent reply other threads:[~2007-10-23 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 17:01 [PATCH] use only the PATH for exec'ing git commands Scott R Parish
2007-10-22 17:44 ` Johannes Schindelin
2007-10-22 19:01 ` Alex Riesen
2007-10-22 19:25 ` Eric Merritt
2007-10-23 4:08 ` [PATCH trailing ws fixed] " Scott Parish
2007-10-23 21:12 ` Alex Riesen [this message]
2007-10-23 21:27 ` [PATCH trailing ws fixed] use only the PATH for exec'ing gitcommands Scott R Parish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023211202.GA729@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=sRp@srparish.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).