Re: [PATCH 3/4] Build-in send-pack, with an API for other programs to call.

["Shawn O. Pearce" <spearce@spearce.org>]

Daniel Barkalow <barkalow@iabervon.org> wrote:
> -int main(int argc, char **argv)
> +void setup_send_pack(struct send_pack_args *args)
> +{
> +	receivepack = args->receivepack;
> +	verbose = args->verbose;
> +	send_all = args->send_all;
> +	force_update = args->force_update;
> +	use_thin_pack = args->use_thin_pack;
> +	dry_run = args->dry_run;
> +}
...
> +struct send_pack_args {
> +	const char *receivepack;
> +	int verbose;
> +	int send_all;
> +	int force_update;
> +	int use_thin_pack;
> +	int dry_run;
> +};
> +

Ick.  How about doing what I did with builtin-fetch-pack.c which
was to copy the args into a global "static struct fetch_pack_args"
and make the struct a bitfield with these boolean items as ":1"
rather than a full int?

-- 
Shawn.