From: Jeff King <peff@peff.net>
To: Matti Aarnio <matti.aarnio@zmailer.org>
Cc: git@vger.kernel.org
Subject: Re: Missing MIME-headers in git-email-tool ..
Date: Tue, 30 Oct 2007 10:06:30 -0400 [thread overview]
Message-ID: <20071030140630.GC21342@coredump.intra.peff.net> (raw)
In-Reply-To: <20071030095338.GZ6372@mea-ext.zmailer.org>
On Tue, Oct 30, 2007 at 11:53:38AM +0200, Matti Aarnio wrote:
> The git-send-email does send posts without any sort of MIME labeling:
>
> From: / To: removed
>
> Subject: [PATCH 0/2] Blackfin I2C/TWI driver updates
> Date: Tue, 30 Oct 2007 17:33:15 +0800
> Message-Id: <1193736797-9005-1-git-send-email-bryan.wu@analog.com>
> X-Mailer: git-send-email 1.5.3.4
> Precedence: bulk
>
>
> which per MIME rules means that the message in question is equivalent
> to one with header labels:
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: 7bit
As Johannes explained, this happens only when there are no >7bit
characters in the email, so that interpretation is correct. Though I am
not opposed to sending those headers all the time, for clarity's sake.
> What would be a problem ? Some of us have names that are encoded
> in 8-bit form, and some receiving systems get all mighty upset when
> they receive unlabelled email carry 8-bit encoded texts.
> (Thanks to chinese and russian spammers..)
Then git-send-email should be generating the MIME headers if there are
8-bit characters. Can you produce a test case where the most recent
version of git-send-email it does not?
> Now if the git-send-email would add following three lines in all
> outgoing email headers, things would be 99% correct for a long time..
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=ISO-8859-15
> Content-Transfer-Encoding: 8BIT
No, this is just wrong. If git-send-email isn't adding headers when it
should to 8-bit output, then it's a bug. But papering over it with a
randomly chosen, possibly incorrect charset is not the right answer.
-Peff
next prev parent reply other threads:[~2007-10-30 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 9:53 Missing MIME-headers in git-email-tool Matti Aarnio
2007-10-30 10:31 ` Johannes Schindelin
2007-10-30 11:27 ` Matti Aarnio
2007-10-30 12:07 ` Johannes Schindelin
2007-10-30 14:06 ` Jeff King [this message]
2007-10-30 14:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030140630.GC21342@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=matti.aarnio@zmailer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).