From: Jeff King <peff@peff.net>
To: Erik Mouw <mouw@nl.linux.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Karl Hasselstr?m <kha@treskal.com>, Bill Lear <rael@zopyra.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Get rid of cpio in git-clone (was: Re: cpio command not found)
Date: Wed, 31 Oct 2007 16:22:21 -0400 [thread overview]
Message-ID: <20071031202220.GA13300@coredump.intra.peff.net> (raw)
In-Reply-To: <20071031201425.GA29332@gateway.home>
On Wed, Oct 31, 2007 at 09:14:25PM +0100, Erik Mouw wrote:
> > Patch, please?
>
> Here you go.
Good, now we have something to critique. :)
> - find objects -depth -print | cpio -pumd$l "$GIT_DIR/" || exit 1
> + cp -Rp$l objects/ "$GIT_DIR/" || exit 1
cp -l isn't even close to portable. It's not in POSIX, and doesn't work
on (at least) Solaris.
I think Mike's patch (cpio if available, copy otherwise) is a reasonable
approach. If there are other methods (and I think cp -l is not
unreasonable for systems where it is supported and cpio is unavailable),
then perhaps it is worth trying them one by one and dropping back to
full copy if all fail.
-Peff
next prev parent reply other threads:[~2007-10-31 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 12:51 cpio command not found Bill Lear
2007-10-31 13:30 ` Karl Hasselström
2007-10-31 13:54 ` Bill Lear
2007-10-31 13:58 ` Allan Wind
2007-10-31 14:00 ` David Symonds
2007-10-31 14:06 ` Erik Mouw
2007-10-31 14:20 ` Johannes Schindelin
2007-10-31 20:14 ` [PATCH] Get rid of cpio in git-clone (was: Re: cpio command not found) Erik Mouw
2007-10-31 20:22 ` Jeff King [this message]
2007-10-31 19:48 ` cpio command not found Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031202220.GA13300@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=mouw@nl.linux.org \
--cc=rael@zopyra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).