From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
Date: Fri, 2 Nov 2007 00:36:11 +0100 [thread overview]
Message-ID: <200711020036.12715.jnareb@gmail.com> (raw)
In-Reply-To: <7vve8l8va0.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> It does appear to do nothing; gitweb is run as standalone program
>> and not as CGI script in this test. This call caused problems later.
>
> Care to describe "later problems" a bit more?
Sorry about that. The problems were while creating yet-to-be send
patch
"gitweb: Add tests for overriding gitweb config with repo config"
Perhaps not in the current version. I forgot details.
Perhaps last sentence "This call caused problems later." should be
simply removed from commit message.
--
Jakub Narebski
Poland
prev parent reply other threads:[~2007-11-01 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 13:23 [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test Jakub Narebski
2007-11-01 22:18 ` Junio C Hamano
2007-11-01 23:36 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711020036.12715.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).