From: Mike Hommey <mh@glandium.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Reuse previous annotation when overwriting a tag
Date: Sat, 3 Nov 2007 14:10:30 +0100 [thread overview]
Message-ID: <20071103131030.GA18670@glandium.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711031236160.4362@racer.site>
On Sat, Nov 03, 2007 at 12:36:36PM +0000, Johannes Schindelin wrote:
> Hi,
>
> On Sat, 3 Nov 2007, Mike Hommey wrote:
>
> > On Sat, Nov 03, 2007 at 11:54:38AM +0000, Johannes Schindelin wrote:
> > > Why not teach write_annotations() (or write_tag_body() like I would prefer
> > > it to be called) to grok a null_sha1? It's not like we care for
> > > performance here, but rather for readability and ease of use.
> >
> > By the way, I think it would be much better if this function was made
> > more generic and would not write, but return an strbuf containing the
> > object body. It could also be used by e.g. git-commit --amend.
> >
> > What would be the best suited place for such a function ?
>
> editor.c, I'd say.
On which topic is this ?
Mike
next prev parent reply other threads:[~2007-11-03 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 9:31 [PATCH] Reuse previous annotation when overwriting a tag Mike Hommey
2007-11-03 11:54 ` Johannes Schindelin
2007-11-03 12:10 ` Mike Hommey
2007-11-03 12:23 ` Johannes Schindelin
2007-11-03 13:08 ` [PATCH 1/2] " Mike Hommey
2007-11-03 13:08 ` [PATCH 2/2] Small code readability improvement in show_reference() in builtin-tag.c Mike Hommey
2007-11-07 21:51 ` Mike Hommey
2007-11-03 18:47 ` [PATCH 1/2] Reuse previous annotation when overwriting a tag Junio C Hamano
2007-11-03 19:55 ` Mike Hommey
2007-11-04 0:11 ` Mike Hommey
2007-11-04 0:11 ` [PATCH 2/2] Add tests for git tag Mike Hommey
2007-11-03 12:27 ` [PATCH] Reuse previous annotation when overwriting a tag Mike Hommey
2007-11-03 12:36 ` Johannes Schindelin
2007-11-03 13:10 ` Mike Hommey [this message]
2007-11-03 13:22 ` Johannes Schindelin
2007-11-03 13:59 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071103131030.GA18670@glandium.org \
--to=mh@glandium.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).