* [PATCH] git-svn: sort the options in the --help message.
@ 2007-11-03 18:53 Benoit Sigoure
2007-11-03 19:42 ` Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Benoit Sigoure @ 2007-11-03 18:53 UTC (permalink / raw)
To: git; +Cc: gitster, normalperson, Benoit Sigoure
* git-svn.perl (&usage): Sort the various options.
Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
---
It always annoys me when I read the output of git svn <cmd> --help that the
options are printed in no particular order.
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 22bb47b..4900f57 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -252,7 +252,7 @@ Usage: $0 <command> [options] [arguments]\n
next if $cmd && $cmd ne $_;
next if /^multi-/; # don't show deprecated commands
print $fd ' ',pack('A17',$_),$cmd{$_}->[1],"\n";
- foreach (keys %{$cmd{$_}->[2]}) {
+ foreach (sort keys %{$cmd{$_}->[2]}) {
# mixed-case options are for .git/config only
next if /[A-Z]/ && /^[a-z]+$/i;
# prints out arguments as they should be passed:
--
1.5.3.4.398.g859b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-svn: sort the options in the --help message.
2007-11-03 18:53 [PATCH] git-svn: sort the options in the --help message Benoit Sigoure
@ 2007-11-03 19:42 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2007-11-03 19:42 UTC (permalink / raw)
To: Benoit Sigoure; +Cc: git, gitster
Benoit Sigoure <tsuna@lrde.epita.fr> wrote:
> * git-svn.perl (&usage): Sort the various options.
>
> Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
> ---
> It always annoys me when I read the output of git svn <cmd> --help that the
> options are printed in no particular order.
The above sentence belongs in the commit message.
Thanks,
Acked-by: Eric Wong <normalperson@yhbt.net>
> git-svn.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 22bb47b..4900f57 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -252,7 +252,7 @@ Usage: $0 <command> [options] [arguments]\n
> next if $cmd && $cmd ne $_;
> next if /^multi-/; # don't show deprecated commands
> print $fd ' ',pack('A17',$_),$cmd{$_}->[1],"\n";
> - foreach (keys %{$cmd{$_}->[2]}) {
> + foreach (sort keys %{$cmd{$_}->[2]}) {
> # mixed-case options are for .git/config only
> next if /[A-Z]/ && /^[a-z]+$/i;
> # prints out arguments as they should be passed:
--
Eric Wong
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-03 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-03 18:53 [PATCH] git-svn: sort the options in the --help message Benoit Sigoure
2007-11-03 19:42 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).