From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Steffen Prohaska <prohaska@zib.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] user-manual: add advanced topic "bisecting merges"
Date: Sun, 4 Nov 2007 12:23:02 +0100 [thread overview]
Message-ID: <20071104112302.GA2119@ins.uni-bonn.de> (raw)
In-Reply-To: <11941677732664-git-send-email-prohaska@zib.de>
Hello Steffen,
A couple of language nits:
* Steffen Prohaska wrote on Sun, Nov 04, 2007 at 10:16:13AM CET:
> +Suppose that on the upper development line, the meaning of one
> +of the functions existed at Z was changed at commit X. The
s/functions/& that/
> +commits from Z leading to A change both the function's
> +implementation and all calling sites that existed at Z, as well
> +as new calling sites they add, to be consistent. There is no
> +bug at A.
[...]
> +You merge to create C. There is no textual conflict with this
> +three way merge, and the result merges cleanly. You bisect
> +this, because you found D is bad and you know Z was good. Your
> +bisect will find that C (merge) is broken. Understandably so,
> +as at C, the new calling site of the function added by the lower
> +branch is not converted to the new semantics, while all the
> +other calling sites that already existed at Z would have been
> +converted by the merge. The new calling site has semantic
> +adjustment needed, but you do not know that yet. You need to
> +find out that is the cause of the breakage by looking at the
s/that/that that/
> +merge commit C and the history leading to it.
[...]
> +If you linearlize the history by rebasing the lower branch on
> +top of upper, instead of merging, the bug becomes much easier to
s/upper/the &/
> +find and understand. Your history would instead be:
[...]
Cheers,
Ralf
next prev parent reply other threads:[~2007-11-04 11:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 9:16 [PATCH] user-manual: add advanced topic "bisecting merges" Steffen Prohaska
2007-11-04 11:23 ` Ralf Wildenhues [this message]
2007-11-07 21:50 ` [PATCH v2] " Steffen Prohaska
2007-11-07 22:16 ` Benoit Sigoure
2007-11-07 22:26 ` J. Bruce Fields
2007-11-08 6:40 ` Steffen Prohaska
2007-11-08 7:19 ` Johannes Sixt
2007-11-08 8:59 ` Steffen Prohaska
2007-11-08 9:11 ` Johannes Sixt
2007-11-08 9:33 ` Andreas Ericsson
2007-11-08 9:53 ` Johannes Sixt
2007-11-08 12:54 ` Steffen Prohaska
2007-11-08 13:22 ` Johannes Sixt
2007-11-08 14:55 ` Steffen Prohaska
2007-11-10 9:48 ` [PATCH v3] " Steffen Prohaska
2007-11-10 10:36 ` Junio C Hamano
2007-11-10 11:16 ` Steffen Prohaska
2007-11-10 13:49 ` [PATCH v4] user-manual: Add section "Why bisecting merge commits can be harder ..." Steffen Prohaska
2007-11-10 19:10 ` Linus Torvalds
2007-11-10 20:25 ` Junio C Hamano
2007-11-10 22:41 ` Steffen Prohaska
2007-11-18 3:59 ` J. Bruce Fields
2007-11-18 9:47 ` Steffen Prohaska
2007-11-18 23:18 ` J. Bruce Fields
2007-11-08 13:38 ` [PATCH v2] user-manual: add advanced topic "bisecting merges" Andreas Ericsson
2007-11-08 14:51 ` Benoit Sigoure
2007-11-08 15:07 ` Steffen Prohaska
2007-11-08 15:23 ` Johannes Schindelin
2007-11-08 18:38 ` Brian Gernhardt
2007-11-04 13:50 ` [PATCH] " Benoit SIGOURE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071104112302.GA2119@ins.uni-bonn.de \
--to=ralf.wildenhues@gmx.de \
--cc=git@vger.kernel.org \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).