From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Riesen Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Date: Mon, 5 Nov 2007 23:52:58 +0100 Message-ID: <20071105225258.GC4208@steel.home> References: <20071026141539.29928.qmail@d3691352d65cf2.315fe32.mid.smarden.org> <20071026160118.GA5076@ferdyx.org> <20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org> Reply-To: Alex Riesen Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Fernando J. Pereda" , git@vger.kernel.org, Junio C Hamano To: Gerrit Pape X-From: git-owner@vger.kernel.org Mon Nov 05 23:53:33 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpAp0-0005HM-UX for gcvg-git-2@gmane.org; Mon, 05 Nov 2007 23:53:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754453AbXKEWxF (ORCPT ); Mon, 5 Nov 2007 17:53:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754332AbXKEWxD (ORCPT ); Mon, 5 Nov 2007 17:53:03 -0500 Received: from mo-p07-ob.rzone.de ([81.169.146.188]:22951 "EHLO mo-p07-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754509AbXKEWxB (ORCPT ); Mon, 5 Nov 2007 17:53:01 -0500 Received: from tigra.home (Facbb.f.strato-dslnet.de [195.4.172.187]) by post.webmailer.de (mrclete mo56) (RZmta 14.0) with ESMTP id 502758jA5KhYOM ; Mon, 5 Nov 2007 23:52:58 +0100 (MET) (envelope-from: ) Received: from steel.home (steel.home [192.168.1.2]) by tigra.home (Postfix) with ESMTP id B3014277AE; Mon, 5 Nov 2007 23:52:58 +0100 (CET) Received: by steel.home (Postfix, from userid 1000) id 972F956D22; Mon, 5 Nov 2007 23:52:58 +0100 (CET) Content-Disposition: inline In-Reply-To: <20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-RZG-AUTH: z4gQVF2k5XWuW3CculzzcFz5CxQ= X-RZG-CLASS-ID: mo07 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Gerrit Pape, Mon, Nov 05, 2007 13:49:20 +0100: > + for (i = 0; i < 2; ++i) { > + snprintf(name, sizeof(name), "%s/%s", path, sub[i]); > + if ((dir = opendir(name)) == NULL) { > + error("cannot opendir %s (%s)", name, strerror(errno)); > + return -1; > + } Why is missing "cur" (or "new", for that matter) a fatal error? Why is it error at all? How about just ignoring the fact?