From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Date: Tue, 6 Nov 2007 10:47:40 -0500 Message-ID: <20071106154740.GA24505@sigill.intra.peff.net> References: <20071026141539.29928.qmail@d3691352d65cf2.315fe32.mid.smarden.org> <20071026160118.GA5076@ferdyx.org> <20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org> <20071105225258.GC4208@steel.home> <635FFEC2-2489-443B-8425-DF2B58BE23C2@mac.com> <20071106072831.GA3021@steel.home> <20071106075150.GA21694@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alex Riesen , Michael Cohen , Gerrit Pape , "Fernando J. Pereda" , git@vger.kernel.org, Junio C Hamano To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Nov 06 16:48:02 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpQen-0006Lb-G4 for gcvg-git-2@gmane.org; Tue, 06 Nov 2007 16:48:01 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbXKFPrq (ORCPT ); Tue, 6 Nov 2007 10:47:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752416AbXKFPrp (ORCPT ); Tue, 6 Nov 2007 10:47:45 -0500 Received: from 66-23-211-5.clients.speedfactory.net ([66.23.211.5]:3563 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbXKFPrp (ORCPT ); Tue, 6 Nov 2007 10:47:45 -0500 Received: (qmail 31326 invoked by uid 111); 6 Nov 2007 15:47:42 -0000 Received: from c-24-125-35-113.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (24.125.35.113) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.32) with ESMTP; Tue, 06 Nov 2007 10:47:42 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 06 Nov 2007 10:47:40 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote: > > > So? Why *STOP* reading the mails if just one of the directories could > > > not be opened? IOW, I suggest: > > > > Because you are then trying to apply a patch series with some patches > > potentially missing? Continuing only on errno == ENOENT seems prudent. > > I fail to see how the absence of one of cur/ or new/ can lead to the > absence of patches. You could forget to save some patches, yes, but the > presence of cur/ and new/ is no indicator for that. Read my message again. Alex is proposing ignoring errors in opening the directories; I am proposing ignoring such errors _only_ when the error is that the directory does not exist. IOW, if there is some other error in opening the directory, it should be fatal, because you might be missing patches. -Peff