git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Habouzit <madcoder@debian.org>
To: Brian Downing <bdowning@lavos.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	tsuna@lrde.epita.fr, aghilesk@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Mark 'git stash [message...]' as deprecated
Date: Wed, 07 Nov 2007 09:23:45 +0100	[thread overview]
Message-ID: <20071107082345.GA18057@artemis.corp> (raw)
In-Reply-To: <1194395205-27905-1-git-send-email-bdowning@lavos.net>

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Wed, Nov 07, 2007 at 12:26:44AM +0000, Brian Downing wrote:
> Complain to STDERR unless 'git stash save' is explicitly used.
> This is in preparation for completely disabling the "default save"
> behavior of the command in the future.

  No arguments at all should not IMHO be deprecated, it's very useful,
and is not ambiguous. The issue with git stash <random> is that if you
thought you typed a command that doesn't in fact exists, you stash which
is not what you meant _at all_.

  When you type `git stash` you certainly want to stash, and it's what
it does.

Here is how it should work:

git-stash (list | show [<stash>] | apply [<stash>] | clear)
git-stash [save <message>]


-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-11-07  8:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 21:52 git pull opinion Aghiles
2007-11-05 22:28 ` Jakub Narebski
2007-11-06  0:08   ` Johannes Schindelin
2007-11-06  4:22     ` Aghiles
2007-11-06 12:02       ` Johannes Schindelin
2007-11-06 18:13         ` Junio C Hamano
2007-11-06 18:28           ` Johannes Schindelin
2007-11-05 22:49 ` Alex Riesen
2007-11-05 23:33 ` Junio C Hamano
2007-11-06  0:36   ` Bill Lear
2007-11-06  0:46     ` Pierre Habouzit
2007-11-06  7:38       ` Alex Riesen
2007-11-06  8:31         ` Pierre Habouzit
2007-11-06  0:54     ` Andreas Ericsson
2007-11-06  1:16       ` Johannes Schindelin
2007-11-06  8:59         ` Andreas Ericsson
2007-11-06 12:05           ` Johannes Schindelin
2007-11-06 12:08             ` Andreas Ericsson
2007-11-06  6:30     ` Aghiles
2007-11-06  7:40       ` Alex Riesen
2007-11-06 16:36       ` Linus Torvalds
2007-11-07 21:25         ` Aghiles
2007-11-08 15:27           ` Johannes Schindelin
2007-11-10  0:36           ` Linus Torvalds
2007-11-06  0:37   ` Steven Grimm
2007-11-06  4:04   ` Aghiles
2007-11-05 23:40 ` Miklos Vajna
2007-11-06  4:16   ` Aghiles
2007-11-06  5:29     ` Benoit Sigoure
2007-11-06  7:34       ` Ralf Wildenhues
2007-11-06 11:59         ` Johannes Schindelin
2007-11-06 20:22           ` Ralf Wildenhues
2007-11-06  7:45       ` Aghiles
2007-11-06  8:51       ` Pierre Habouzit
2007-11-07  0:26         ` [PATCH] Mark 'git stash [message...]' as deprecated Brian Downing
2007-11-07  0:26           ` [PATCH] Disable implicit 'save' argument for 'git stash' Brian Downing
2007-11-07  8:00           ` [PATCH] Mark 'git stash [message...]' as deprecated Johannes Sixt
2007-11-07  8:12             ` Wincent Colaiuta
2007-11-07  8:02           ` Junio C Hamano
2007-11-07  8:23           ` Pierre Habouzit [this message]
2007-11-06 18:07 ` git pull opinion Pascal Obry
2007-11-07  7:06   ` Uwe Kleine-König
2007-11-07  7:40     ` Pascal Obry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071107082345.GA18057@artemis.corp \
    --to=madcoder@debian.org \
    --cc=aghilesk@gmail.com \
    --cc=bdowning@lavos.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tsuna@lrde.epita.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).