git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: "Michael J. Cohen" <michaeljosephcohen@mac.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Re: git-svn fetch doesn't like spaces in branch names
Date: Thu, 8 Nov 2007 08:29:18 +0100	[thread overview]
Message-ID: <20071108072918.GC3170@steel.home> (raw)
In-Reply-To: <B28A099B-1BC8-4CED-856A-5FFD7F6711FC@mac.com>

Michael J. Cohen, Thu, Nov 08, 2007 01:53:07 +0100:
>> mini:TextMateBundles mjc$ git-svn fetch
>> Found possible branch point: 
>> http://macromates.com/svn/Bundles/trunk/Tools/Dialog PlugIn => 
>> http://macromates.com/svn/Bundles/branches/Dialog PlugIn Completion Menu, 
>> 8089
>> Initializing parent: Dialog PlugIn Completion Menu@8089
>> Bad URL passed to RA layer: Malformed URL for repository at 
>> /opt/local/bin/git-svn line 1607
>>
>> looks like that might need to be %20 ?
>
>
> Hacky, but it works.
>
> Signed-off-by: Michael J. Cohen <mjc@cruiseplanners.com>
>
> diff --git a/git-svn.perl b/git-svn.perl
> index dd93e32..5dc3b9c 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1976,6 +1976,7 @@ sub find_parent_branch {
> 	my $r = $i->{copyfrom_rev};
> 	my $repos_root = $self->ra->{repos_root};
> 	my $url = $self->ra->{url};
> +	$branch_from =~ s@([\s])@sprintf("%%%02X", ord($1))@seg;

You don't need "[" and "]".

  reply	other threads:[~2007-11-08  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08  0:14 git-svn fetch doesn't like spaces in branch names Michael J. Cohen
2007-11-08  0:53 ` [PATCH] " Michael J. Cohen
2007-11-08  7:29   ` Alex Riesen [this message]
2007-11-08  8:49     ` Benoit Sigoure
2007-11-12  7:37 ` [PATCH] git-svn: support for funky branch and project names over HTTP(S) Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071108072918.GC3170@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=michaeljosephcohen@mac.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).