From: Jeff King <peff@peff.net>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Junio C Hamano <gitster@pobox.com>,
Paul Mackerras <paulus@samba.org>,
Git Mailing List <git@vger.kernel.org>,
Pierre Habouzit <madcoder@debian.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/2] --pretty=format: on-demand format expansion
Date: Thu, 8 Nov 2007 23:52:56 -0500 [thread overview]
Message-ID: <20071109045256.GD31760@sigill.intra.peff.net> (raw)
In-Reply-To: <4733AEA6.1040802@lsrfire.ath.cx>
On Fri, Nov 09, 2007 at 01:49:42AM +0100, René Scharfe wrote:
> + strbuf_expand(sb, format, placeholders, format_commit_item, (void *)commit);
This void cast is pointless, since all pointers types convert implicitly
to void pointers anyway. At best, it does nothing, and at worst, it
hides an actual type error if the function signature or the type of
'commit' change.
(In the patch I just sent out, I had to change this line anyway, and
removed the cast).
-Peff
next prev parent reply other threads:[~2007-11-09 4:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 0:49 [PATCH 2/2] --pretty=format: on-demand format expansion René Scharfe
2007-11-09 1:24 ` Johannes Schindelin
2007-11-09 21:13 ` René Scharfe
2007-11-09 22:18 ` Johannes Schindelin
2007-11-09 22:30 ` Junio C Hamano
2007-11-09 4:50 ` Jeff King
2007-11-09 23:16 ` René Scharfe
2007-11-10 0:31 ` Johannes Schindelin
2007-11-10 0:49 ` Jeff King
2007-11-10 0:46 ` Jeff King
2007-11-10 11:12 ` René Scharfe
2007-11-10 16:07 ` Johannes Schindelin
2007-11-10 16:24 ` René Scharfe
2007-11-10 20:36 ` Jeff King
2007-11-10 20:34 ` Jeff King
2007-11-11 8:13 ` Jeff King
2007-11-10 11:14 ` [PATCH 1/3] --pretty=format: parse commit message only once René Scharfe
2007-11-10 11:16 ` [PATCH 2/3] add strbuf_adddup() René Scharfe
2007-11-10 11:18 ` [PATCH 3/3] --format=pretty: avoid calculating expensive expansions twice René Scharfe
2007-11-11 10:29 ` Junio C Hamano
2007-11-09 4:52 ` Jeff King [this message]
2007-11-09 23:20 ` [PATCH 2/2] --pretty=format: on-demand format expansion René Scharfe
2007-11-10 0:51 ` Jeff King
2007-11-09 23:39 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109045256.GD31760@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=paulus@samba.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).