From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <junio@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] rev-list: Introduce --no-output to avoid /dev/null redirects
Date: Fri, 9 Nov 2007 09:12:04 +0100 [thread overview]
Message-ID: <20071109081204.GB2794@steel.home> (raw)
In-Reply-To: <7vejezx4b2.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Fri, Nov 09, 2007 08:32:01 +0100:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > @@ -640,7 +656,9 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
> > }
> > }
> >
> > - traverse_commit_list(&revs, show_commit, show_object);
> > + traverse_commit_list(&revs,
> > + nooutput ? noshow_commit : show_commit,
> > + nooutput ? noshow_object : show_object);
> >
> > return 0;
> > }
>
> The function names noshow_xxx() looked a bit funny, but I do not
> offhand have better alternatives to offer.
"hide", "skip", "ignore"?
next prev parent reply other threads:[~2007-11-09 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 8:00 [PATCH 2/3] rev-list: Introduce --no-output to avoid /dev/null redirects Shawn O. Pearce
2007-11-08 23:44 ` Alex Riesen
2007-11-09 7:32 ` Junio C Hamano
2007-11-09 8:12 ` Alex Riesen [this message]
2007-11-09 8:58 ` Junio C Hamano
2007-11-09 9:12 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109081204.GB2794@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).