From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink Subject: Re: `git-send-email' doesn't specify `Content-Type' Date: Sat, 10 Nov 2007 13:51:26 +0100 Message-ID: <20071110125126.GA7261@atjola.homenet> References: <87ode3klc7.fsf@chbouib.org> <20071110101420.GA21353@bulgaria> <20071110122528.GA4977@atjola.homenet> <20071110123505.GA24445@bulgaria> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Johannes Schindelin , Ludovic =?iso-8859-1?Q?Court=E8s?= , git@vger.kernel.org To: Brian Swetland X-From: git-owner@vger.kernel.org Sat Nov 10 13:51:49 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqpoR-00057P-NM for gcvg-git-2@gmane.org; Sat, 10 Nov 2007 13:51:48 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbXKJMva convert rfc822-to-quoted-printable (ORCPT ); Sat, 10 Nov 2007 07:51:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751855AbXKJMva (ORCPT ); Sat, 10 Nov 2007 07:51:30 -0500 Received: from mail.gmx.net ([213.165.64.20]:34036 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752000AbXKJMv3 (ORCPT ); Sat, 10 Nov 2007 07:51:29 -0500 Received: (qmail invoked by alias); 10 Nov 2007 12:51:27 -0000 Received: from i577BBC4D.versanet.de (EHLO localhost) [87.123.188.77] by mail.gmx.net (mp052) with SMTP; 10 Nov 2007 13:51:27 +0100 X-Authenticated: #5039886 X-Provags-ID: V01U2FsdGVkX1/d25pYuuDdkxcBLW5qEay0EelgNQvaON5h5kNXrl IsUl5WarTODo0o Content-Disposition: inline In-Reply-To: <20071110123505.GA24445@bulgaria> User-Agent: Mutt/1.5.17 (2007-11-01) X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On 2007.11.10 04:35:05 -0800, Brian Swetland wrote: > [Bj=F6rn Steinbrink ] > > On 2007.11.10 02:14:20 -0800, Brian Swetland wrote: > > >=20 > > > The example I have involves a coworker's name which needs non-asc= ii > > > characters. They are properly escaped in the From: line generate= d by > > > git-format-patch. git-send-email puts the generated From: line a= t the > > > top of the body of the email, unescapes it (to utf-8), and procee= ds to > > > send the email with no Content-Type specified. > >=20 > > You mean that it converts the header field to utf-8? It doesn't do = that > > here (neither master nor 1.5.3.5) and IIRC that would be invalid an= yway, > > because Content-Type applies to exactly that, content, not headers.= Your > > sample has no non-ASCII characters (or at least I didn't see any), = so > > git-send-email doesn't add a header to specify a charset. >=20 > The first line of the patch is a From: field with Arve's name, in > an (rfc822?) encoded format): > From: =3D?utf-8?q?Arve=3D20Hj=3DC3=3DB8nnev=3DC3=3DA5g?=3D >=20 > The mail generated by git-send-email makes this From: line the first > line of the *body* of the generated email. This line in the body > is no longer escaped, the utf8 characters are visible, but the header > of the message does not have a Content-Type indicating a non-ascii > encoding. Ah! Commit author differs from mail sender, didn't think of that. That'= s probably the same problem as with the -s option, ie. that git-send-emai= l only looks at the existing text and not add anything it adds itself whe= n checking the encoding. Sorry for the noise. Bj=F6rn