From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: [PATCH 1/5] Fix memory leak in traverse_commit_list Date: Sun, 11 Nov 2007 02:29:23 -0500 Message-ID: <20071111072923.GA19146@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Sun Nov 11 08:29:51 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ir7GR-0003H1-Bl for gcvg-git-2@gmane.org; Sun, 11 Nov 2007 08:29:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbXKKH31 (ORCPT ); Sun, 11 Nov 2007 02:29:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751407AbXKKH31 (ORCPT ); Sun, 11 Nov 2007 02:29:27 -0500 Received: from corvette.plexpod.net ([64.38.20.226]:41442 "EHLO corvette.plexpod.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbXKKH30 (ORCPT ); Sun, 11 Nov 2007 02:29:26 -0500 Received: from [74.70.48.173] (helo=asimov.home.spearce.org) by corvette.plexpod.net with esmtpa (Exim 4.68) (envelope-from ) id 1Ir7G1-0000zE-7E; Sun, 11 Nov 2007 02:29:25 -0500 Received: by asimov.home.spearce.org (Postfix, from userid 1000) id 6C81C20FBAE; Sun, 11 Nov 2007 02:29:23 -0500 (EST) Content-Disposition: inline User-Agent: Mutt/1.5.11 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - corvette.plexpod.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spearce.org Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: If we were listing objects too then the objects were buffered in an array only reachable from a stack allocated structure. When this function returns that array would be leaked as nobody would have a reference to it anymore. Historically this hasn't been a problem as the primary user of traverse_commit_list() (the noble git-rev-list) would terminate as soon as the function was finished, thus allowing the operating system to cleanup memory. However we have been leaking this data in git-pack-objects ever since that program learned how to run the revision listing internally, rather than relying on reading object names from git-rev-list. To better facilitate reuse of traverse_commit_list during other builtin tools we shouldn't leak temporary memory like this and instead we need to clean up properly after ourselves. Signed-off-by: Shawn O. Pearce --- list-objects.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/list-objects.c b/list-objects.c index e5c88c2..4ef58e7 100644 --- a/list-objects.c +++ b/list-objects.c @@ -170,4 +170,11 @@ void traverse_commit_list(struct rev_info *revs, } for (i = 0; i < objects.nr; i++) show_object(&objects.objects[i]); + free(objects.objects); + if (revs->pending.nr) { + free(revs->pending.objects); + revs->pending.nr = 0; + revs->pending.alloc = 0; + revs->pending.objects = NULL; + } } -- 1.5.3.5.1661.gcbf0