From: Pierre Habouzit <madcoder@debian.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: Re: [PATCH 5/6] builtin-commit: resurrect behavior for multiple -m options
Date: Sun, 11 Nov 2007 23:13:14 +0100 [thread overview]
Message-ID: <20071111221314.GE13200@artemis.corp> (raw)
In-Reply-To: <Pine.LNX.4.64.0711112039130.4362@racer.site>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Sun, Nov 11, 2007 at 08:42:48PM +0000, Johannes Schindelin wrote:
> Well, I meant to mention it in the cover letter. My preference is to do
> away with the extra empty line. But this might break existing setups
> depending on that behaviour.
In fact I believe what matters is that if there is more than one -m,
you have a \n\n between the first and the second one, else it'll break
subjects, and that sucks, so I'd say we have to stay with "\n\n" at
least for the first aggregation, and I'm unsure if it's worth the hassle
to count how many times we aggregated to use '\n' then.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-11 22:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 17:35 [PATCH 0/6] Various (replacement) patches to builtin-commit Johannes Schindelin
2007-11-11 17:35 ` [PATCH 1/6] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-12 19:38 ` Kristian Høgsberg
2007-11-12 20:12 ` Johannes Schindelin
2007-11-13 0:37 ` Junio C Hamano
2007-11-11 17:35 ` [PATCH 2/6] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-11 17:35 ` [PATCH 3/6] builtin-commit: fix --signoff Johannes Schindelin
2007-11-11 17:36 ` [PATCH 4/6] builtin-commit --s: add a newline if the last line was no S-O-B Johannes Schindelin
2007-11-11 17:36 ` [PATCH 5/6] builtin-commit: resurrect behavior for multiple -m options Johannes Schindelin
2007-11-11 19:42 ` Pierre Habouzit
2007-11-11 20:42 ` Johannes Schindelin
2007-11-11 22:11 ` Pierre Habouzit
2007-11-11 22:13 ` Pierre Habouzit [this message]
2007-11-11 17:36 ` [PATCH 6/6] builtin-commit: Add newline when showing which commit was created Johannes Schindelin
2007-12-01 22:21 ` Jeff King
2007-12-01 22:41 ` Johannes Schindelin
2007-12-02 5:40 ` Jeff King
2007-12-02 12:13 ` Johannes Schindelin
2007-12-02 16:54 ` Jeff King
2007-12-02 17:18 ` Johannes Schindelin
2007-12-02 18:34 ` Junio C Hamano
2007-12-02 21:20 ` Johannes Schindelin
2007-12-03 7:33 ` Junio C Hamano
2007-12-03 7:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111221314.GE13200@artemis.corp \
--to=madcoder@debian.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).