From: Jeff King <peff@peff.net>
To: David Symonds <dsymonds@gmail.com>
Cc: Wincent Colaiuta <win@wincent.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Grammar fixes for gitattributes documentation
Date: Thu, 15 Nov 2007 02:27:03 -0500 [thread overview]
Message-ID: <20071115072703.GF10185@sigill.intra.peff.net> (raw)
In-Reply-To: <ee77f5c20711142320x1a070b21xf00f0853fe09e34c@mail.gmail.com>
On Thu, Nov 15, 2007 at 06:20:10PM +1100, David Symonds wrote:
> > >>> +A `filter` attribute can be set to a string value which names a
> > >>> filter driver specified in the configuration.
>
> "that" should be used to introduce restrictive clauses (as you point
> out), and this use should be a restrictive clause, since you can't set
> the attribute to just any value--you need to set it to the value
> *that* names the desired filter driver.
I don't see it as restrictive, but I can see how one would. I think it
is not a case of "this wording is correct" but rather "this wording
means one thing, and the other wording means another."
But the two meanings are likely to be interpreted the same way, so I
think it isn't a big deal (although "which" without a comma _is_ wrong
:) ).
-Peff
prev parent reply other threads:[~2007-11-15 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 7:51 [PATCH] Grammar fixes for gitattributes documentation Wincent Colaiuta
2007-11-14 8:55 ` Junio C Hamano
2007-11-14 9:04 ` Wincent Colaiuta
2007-11-14 9:27 ` Junio C Hamano
2007-11-15 7:15 ` Jeff King
2007-11-15 7:20 ` David Symonds
2007-11-15 7:27 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115072703.GF10185@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dsymonds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).