From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Guido Ostkamp <git@ostkamp.fastmail.fm>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Rewrite some function exit paths to avoid "unreachable code" traps
Date: Sat, 17 Nov 2007 15:31:09 +0100 [thread overview]
Message-ID: <200711171531.09545.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20071117122317.GA2716@steel.home>
lördag 17 november 2007 skrev Alex Riesen:
> Robin Rosenberg, Sat, Nov 17, 2007 11:39:32 +0100:
> > lördag 17 november 2007 skrev Alex Riesen:
> > > Noticed by Guido Ostkamp for Sun's Workshop cc.
> > >
> > > Originally-by: Guido Ostkamp <git@ostkamp.fastmail.fm>
> > > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> > > ---
> > > Guido Ostkamp, Fri, Nov 16, 2007 23:52:01 +0100:
> > > >
> > > > What about the xdiff/xdiffi.c problem that should also be solved?
> > > >
> > >
> >
> > Please... This just looks bad. I'm sure we'll have fixup patches on the list
> > to fix those gotos.
> >
> > Do we support any such stupid compiler that requires a dummy goto?
>
> It is more for the compilers we don't know about yet.
>
> Userspace programming, especially with intent to be portable, often
> means supporting *bugs* of the platform where it happens.
*If* it happens. We do not workaround every hypothetical compiler bug or every hypotetical
buggy compiler. Compilers we don't know about does not "exist", expect for the perfectly
confirming ones, but they aren't buggy.
It seems the return in utf8.c was introduced by mistake and Junio has made his decision now.
-- robin
prev parent reply other threads:[~2007-11-17 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 22:19 [PATCH] Fix Solaris compiler warnings Guido Ostkamp
2007-11-15 23:00 ` Alex Riesen
2007-11-15 23:16 ` Junio C Hamano
2007-11-16 7:48 ` Alex Riesen
2007-11-16 9:14 ` Junio C Hamano
2007-11-16 22:52 ` Guido Ostkamp
2007-11-17 9:46 ` [PATCH] Rewrite some function exit paths to avoid "unreachable code" traps Alex Riesen
2007-11-17 10:39 ` Robin Rosenberg
2007-11-17 12:23 ` Alex Riesen
2007-11-17 14:31 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711171531.09545.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@ostkamp.fastmail.fm \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).