Git development
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: David Reiss <dreiss@facebook.com>
Cc: git@vger.kernel.org
Subject: Re: Trivial patch to git-svn
Date: Sat, 17 Nov 2007 13:12:53 -0800	[thread overview]
Message-ID: <20071117211253.GB31598@mayonaise> (raw)
In-Reply-To: <473A1D9F.4030103@facebook.com>

David Reiss <dreiss@facebook.com> wrote:
> From d9f93dc1c503c5f42b27485b2c35b38e8c9bca44 Mon Sep 17 00:00:00 2001
> From: David Reiss <dreiss@dreiss-vmware.(none)>
> Date: Tue, 13 Nov 2007 13:47:26 -0800
> Subject: [PATCH] Fix a typo and add a comma in an error message in git-svn
> 
> Signed-off-by: David Reiss <dreiss@facebook.com>
> ---
>  git-svn.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index e3e00fd..981cdd6 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -391,7 +391,7 @@ sub cmd_set_tree {
>  sub cmd_dcommit {
>  	my $head = shift;
>  	git_cmd_try { command_oneline(qw/diff-index --quiet HEAD/) }
> -		'Cannot dcommit with a dirty index.  Commit your changes 
> first'
> +		'Cannot dcommit with a dirty index.  Commit your changes 
> first, '
>  		. "or stash them with `git stash'.\n";
>  	$head ||= 'HEAD';
>  	my @refs;

I am not an English expert, but both seem acceptable to me.  Anybody else
agree/disagree?

-- 
Eric Wong

  reply	other threads:[~2007-11-17 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13 21:56 Trivial patch to git-svn David Reiss
2007-11-17 21:12 ` Eric Wong [this message]
2007-11-17 21:26   ` Adam Roben
2007-11-17 21:54     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117211253.GB31598@mayonaise \
    --to=normalperson@yhbt.net \
    --cc=dreiss@facebook.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox