git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] git-svn's dcommit must use subversion's config
@ 2007-11-14  0:52 Konstantin V. Arkhipov
  2007-11-17 21:22 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin V. Arkhipov @ 2007-11-14  0:52 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

When doing dcommit git-svn must use subversion's config or newly created
files will not include svn's properties
(defined in [auto-props] with 'enable-auto-props = yes').

Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>
---
--- git-svn	2007-11-02 18:41:32.000000000 +0300
+++ git-svn	2007-11-12 19:35:44.000000000 +0300
@@ -406,6 +406,9 @@ sub cmd_dcommit {
 			my %ed_opts = ( r => $last_rev,
 			                log => get_commit_entry($d)->{log},
 			                ra => Git::SVN::Ra->new($gs->full_url),
+			                config => SVN::Core::config_get_config(
+			                        $Git::SVN::Ra::config_dir
+			                ),
 			                tree_a => "$d~1",
 			                tree_b => $d,
 			                editor_cb => sub {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] git-svn's dcommit must use subversion's config
  2007-11-14  0:52 [PATCH] git-svn's dcommit must use subversion's config Konstantin V. Arkhipov
@ 2007-11-17 21:22 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2007-11-17 21:22 UTC (permalink / raw)
  To: Konstantin V. Arkhipov; +Cc: git, Junio C Hamano

"Konstantin V. Arkhipov" <voxus@onphp.org> wrote:
> When doing dcommit git-svn must use subversion's config or newly created
> files will not include svn's properties
> (defined in [auto-props] with 'enable-auto-props = yes').
> 
> Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>

> ---
> --- git-svn	2007-11-02 18:41:32.000000000 +0300
> +++ git-svn	2007-11-12 19:35:44.000000000 +0300

Thanks Konstantin,

I needed to add '.perl' to the filenames above to get the patch to
apply.  But otherwise,

Acked-by: Eric Wong <normalperson@yhbt.net>

> @@ -406,6 +406,9 @@ sub cmd_dcommit {
>  			my %ed_opts = ( r => $last_rev,
>  			                log => get_commit_entry($d)->{log},
>  			                ra => Git::SVN::Ra->new($gs->full_url),
> +			                config => SVN::Core::config_get_config(
> +			                        $Git::SVN::Ra::config_dir
> +			                ),
>  			                tree_a => "$d~1",
>  			                tree_b => $d,
>  			                editor_cb => sub {

-- 
Eric Wong

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-17 21:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-14  0:52 [PATCH] git-svn's dcommit must use subversion's config Konstantin V. Arkhipov
2007-11-17 21:22 ` Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).