From: Eric Wong <normalperson@yhbt.net>
To: David D Kilzer <ddkilzer@kilzer.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3 v2] git-svn log: handle unreachable revisions like "svn log"
Date: Sat, 17 Nov 2007 13:47:38 -0800 [thread overview]
Message-ID: <20071117214738.GB22835@soma> (raw)
In-Reply-To: <1194850612-6907-1-git-send-email-ddkilzer@kilzer.net>
David D Kilzer <ddkilzer@kilzer.net> wrote:
> When unreachable revisions are given to "svn log", it displays all commit
> logs in the given range that exist in the current tree. (If no commit
> logs are found in the current tree, it simply prints a single commit log
> separator.) This patch makes "git-svn log" behave the same way.
>
> Ten tests added to t/t9116-git-svn-log.sh.
>
> Signed-off-by: David D Kilzer <ddkilzer@kilzer.net>
> ---
>
> No changes were needed to parts 1 and 2 of this series, so I am not
> reposting them.
>
> Updated this patch based on feedback from Benoit Sigoure and Eric Wong:
>
> - Commented find_rev_before() and find_rev_after().
> - Changed commit_log_separator() into a constant.
> - Made return statement safer by adding another check in git_svn_log_cmd().
> - Changed echo statement to printf in t/t9116-git-svn-log.sh.
>
> All tests pass on maint branch.
Thanks,
Acked and pushed out to http://git.bogomips.org/git-svn.git
David D Kilzer (3):
git-svn log: fix ascending revision ranges
git-svn log: include commit log for the smallest revision in a range
git-svn log: handle unreachable revisions like "svn log"
David Reiss (1):
git-svn: Fix a typo and add a comma in an error message in git-svn
Eric Wong (1):
git-svn: add tests for command-line usage of init and clone commands
Konstantin V. Arkhipov (1):
git-svn's dcommit must use subversion's config
--
Eric Wong
next prev parent reply other threads:[~2007-11-17 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 6:10 [PATCH 0/3] git-svn log fixes David D Kilzer
2007-11-11 6:10 ` [PATCH 1/3] git-svn log: fix ascending revision ranges David D Kilzer
2007-11-11 6:10 ` [PATCH 2/3] git-svn log: include commit log for the smallest revision in a range David D Kilzer
2007-11-11 6:10 ` [PATCH 3/3] git-svn log: handle unreachable revisions like "svn log" David D Kilzer
2007-11-11 10:51 ` Benoit Sigoure
2007-11-11 14:20 ` David D. Kilzer
2007-11-11 16:36 ` Benoit Sigoure
2007-11-12 2:50 ` Eric Wong
2007-11-12 6:56 ` [PATCH 3/3 v2] " David D Kilzer
2007-11-17 21:47 ` Eric Wong [this message]
2007-11-18 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117214738.GB22835@soma \
--to=normalperson@yhbt.net \
--cc=ddkilzer@kilzer.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).