git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [Advance Warning PATCH] Move gitk to its own subdirectory
Date: Sun, 18 Nov 2007 00:25:19 +0100	[thread overview]
Message-ID: <20071117232519.GA7664@steel.home> (raw)
In-Reply-To: <7vsl34u1iv.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, Sat, Nov 17, 2007 20:15:20 +0100:
> The plan is to stop merging gitk.git as a single file project
> into git.git but instead use the subtree merge strategy into its
> own subdirectory of git.git.  We can use subproject support in
> the future, but once _a_ subproject is used that means the
> project's history is not pullable with subproject unaware
> versions of git anymore, so I'd avoid it for now.

You made it part of "all" target, which we will have to change if gitk
is to become a subproject: Makefile better handle absence of the
Makefile under gitk-git, and continue build.

> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Makefile              |   14 +++-----------
>  gitk-git/Makefile     |   29 +++++++++++++++++++++++++++++
>  gitk => gitk-git/gitk |    0 
>  3 files changed, 32 insertions(+), 11 deletions(-)
>  create mode 100644 gitk-git/Makefile
>  rename gitk => gitk-git/gitk (100%)
>  mode change 100755 => 100644
...
>  all::
>  ifndef NO_TCLTK
>  	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all
> +	$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all

maybe "git-gitk" instead of "gitk-git"? As "git-gui" and "gitweb"...
Maybe even shorter: "gui", "web" and "k" :)

  reply	other threads:[~2007-11-17 23:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-17 19:15 [Advance Warning PATCH] Move gitk to its own subdirectory Junio C Hamano
2007-11-17 23:25 ` Alex Riesen [this message]
2007-11-18  1:18   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117232519.GA7664@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).