From: Jeff King <peff@peff.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>,
Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH 3/3] send-pack: assign remote errors to each ref
Date: Sat, 17 Nov 2007 19:03:07 -0500 [thread overview]
Message-ID: <20071118000306.GA4000@sigill.intra.peff.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711171258000.12193@iabervon.org>
On Sat, Nov 17, 2007 at 01:05:29PM -0500, Daniel Barkalow wrote:
> Maybe this should take both the full list and the hint and do both passes
> internally? IMHO, the logic in receive_status() looks like it might be
> setting the error twice or not at all, unless you read very carefully.
Not unreasonable, though I started in that direction and it ended up
being less readable (which isn't to say that it's not possible). But it
looks like Junio has merged to next, so I think it is best to leave it
as-is.
-Peff
next prev parent reply other threads:[~2007-11-18 0:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 12:53 [PATCH v3 0/3] tracking per-ref errors on push Jeff King
2007-11-17 12:54 ` [PATCH 1/3] send-pack: track errors for each ref Jeff King
2007-11-17 13:34 ` Alex Riesen
2007-11-17 18:05 ` Daniel Barkalow
2007-11-18 0:13 ` Jeff King
2007-11-18 1:21 ` Junio C Hamano
2007-11-18 3:12 ` Jeff King
2007-11-17 20:53 ` Junio C Hamano
2007-11-18 0:15 ` Jeff King
2007-11-17 12:55 ` [PATCH 2/3] send-pack: check ref->status before updating tracking refs Jeff King
2007-11-17 13:45 ` Alex Riesen
2007-11-17 13:53 ` Jeff King
2007-11-17 18:05 ` Daniel Barkalow
2007-11-17 12:56 ` [PATCH 3/3] send-pack: assign remote errors to each ref Jeff King
2007-11-17 18:05 ` Daniel Barkalow
2007-11-18 0:03 ` Jeff King [this message]
2007-11-18 1:03 ` Junio C Hamano
2007-11-18 2:39 ` Jeff King
2007-11-18 4:47 ` Junio C Hamano
2007-11-18 5:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071118000306.GA4000@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).