git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Downing <bdowning@lavos.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonas Juselius <jonas.juselius@chem.uit.no>
Subject: [PATCH] config: correct and clarify core.*compression documentation
Date: Mon, 19 Nov 2007 09:28:54 -0600	[thread overview]
Message-ID: <20071119152853.GH6212@lavos.net> (raw)

* core.loosecompression stated that the default was "0 (best speed)",
  when in fact 0 is "no compression", and the default is Z_BEST_SPEED,
  which is 1.

* Explain that the default of core.compression is -1, zlib default, and
  add a quote from zlib.h explaining what that actually means.
---
  applies to 'maint'; unfortunately I just noticed 1.5.3.6 went out.

 Documentation/config.txt |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 7ee97df..d62a72b 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -226,13 +226,16 @@ core.compression::
 	An integer -1..9, indicating a default compression level.
 	-1 is the zlib default. 0 means no compression,
 	and 1..9 are various speed/size tradeoffs, 9 being slowest.
+	If not set, defaults to -1 (zlib default), which is "a default
+	compromise between speed and compression (currently equivalent
+	to level 6)."
 
 core.loosecompression::
 	An integer -1..9, indicating the compression level for objects that
 	are not in a pack file. -1 is the zlib default. 0 means no
 	compression, and 1..9 are various speed/size tradeoffs, 9 being
 	slowest.  If not set,  defaults to core.compression.  If that is
-	not set,  defaults to 0 (best speed).
+	not set,  defaults to 1 (best speed).
 
 core.packedGitWindowSize::
 	Number of bytes of a pack file to map into memory in a
-- 
1.5.3.5.1824.g5f389

             reply	other threads:[~2007-11-19 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-19 15:28 Brian Downing [this message]
2007-11-19 15:51 ` [PATCH] config: correct and clarify core.*compression documentation Nicolas Pitre
2007-11-19 16:23   ` Brian Downing
2007-11-19 16:43     ` Nicolas Pitre
2007-11-19 16:46       ` Brian Downing
2007-11-19 16:58       ` [PATCH 1/2] config: correct core.loosecompression documentation Brian Downing
2007-11-19 16:58         ` [PATCH 2/2] config: clarify compression defaults Brian Downing
2007-11-19 17:30           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119152853.GH6212@lavos.net \
    --to=bdowning@lavos.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonas.juselius@chem.uit.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).