From: bdowning@lavos.net (Brian Downing)
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jonas Juselius <jonas.juselius@chem.uit.no>
Subject: Re: [PATCH] config: correct and clarify core.*compression documentation
Date: Mon, 19 Nov 2007 10:46:19 -0600 [thread overview]
Message-ID: <20071119164619.GJ6212@lavos.net> (raw)
In-Reply-To: <alpine.LFD.0.99999.0711191139240.19105@xanadu.home>
On Mon, Nov 19, 2007 at 11:43:56AM -0500, Nicolas Pitre wrote:
> On Mon, 19 Nov 2007, Brian Downing wrote:
> > On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:
> > > > * Explain that the default of core.compression is -1, zlib default, and
> > > > add a quote from zlib.h explaining what that actually means.
> > >
> > > No, this is wrong. core.compression has no default. It is meaningful
> > > only when an explicit value is configured.
> >
> > Would you prefer this?
> >
> > If not set, packs will be compressed to the zlib default level,
> > which is "a default compromise between speed and compression
> > (currently equivalent to level 6)."
>
> This is still rather incorrect. If you want to be thorough, you should
> say that this setting provides a global default for pack.compression and
> core.loosecompression when those settings are not set. Otherwise
> pack.compression and core.loosecompression have a default of their own
> when neither is set.
Okay, thanks. (See, I didn't know this either! :) I'll try to work
with that...
-bcd
next prev parent reply other threads:[~2007-11-19 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 15:28 [PATCH] config: correct and clarify core.*compression documentation Brian Downing
2007-11-19 15:51 ` Nicolas Pitre
2007-11-19 16:23 ` Brian Downing
2007-11-19 16:43 ` Nicolas Pitre
2007-11-19 16:46 ` Brian Downing [this message]
2007-11-19 16:58 ` [PATCH 1/2] config: correct core.loosecompression documentation Brian Downing
2007-11-19 16:58 ` [PATCH 2/2] config: clarify compression defaults Brian Downing
2007-11-19 17:30 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119164619.GJ6212@lavos.net \
--to=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonas.juselius@chem.uit.no \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).