From: Alex Riesen <raa.lkml@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] send-pack: cluster ref status reporting
Date: Tue, 20 Nov 2007 19:22:33 +0100 [thread overview]
Message-ID: <20071120182233.GA3461@steel.home> (raw)
In-Reply-To: <20071120111801.GA7814@sigill.intra.peff.net>
Jeff King, Tue, Nov 20, 2007 12:18:01 +0100:
> Instead of intermingling success and failure, we now print:
>
> 1. all uptodate refs (if args.verbose is enabled)
> 2. successfully pushed refs
> 3. failed refs
I vote for this. The non-ff refs clustered together was the real
reason behind my beautification patch.
> I am somewhat ambivalent on this patch. In most cases, it won't make a
> difference, since the output is small enough. For large pushes, it might
> be better to have errors at the end. OTOH, you do still get "error:
> failed to push to ..." at the end, and you can scroll up and see the
> errors if you like. And it's not like preserving the original ref output
> order was all that interesting.
It is just simplier to distinguish visually: non-ff's are formatted
significantly different. You don't even have to read what is written
to immediately notice if there are problems.
next prev parent reply other threads:[~2007-11-20 18:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 15:12 ! [rejected] master -> master (non-fast forward) Jon Smirl
2007-11-18 18:10 ` Junio C Hamano
2007-11-18 18:42 ` Jon Smirl
2007-11-19 17:47 ` Catalin Marinas
2007-11-19 22:54 ` Jon Smirl
2007-11-20 0:03 ` Daniel Barkalow
2007-11-18 18:29 ` Alex Riesen
2007-11-20 4:16 ` Jeff King
2007-11-20 6:50 ` Alex Riesen
2007-11-20 11:13 ` Jeff King
2007-11-20 11:18 ` [PATCH 1/2] send-pack: cluster ref status reporting Jeff King
2007-11-20 18:22 ` Alex Riesen [this message]
2007-11-21 7:24 ` Junio C Hamano
2007-11-21 7:33 ` Jeff King
2007-11-21 7:36 ` Junio C Hamano
2007-11-21 7:39 ` Jeff King
2007-11-21 7:37 ` Jeff King
2007-11-20 11:21 ` [PATCH 2/2] send-pack: print "maybe you need to pull" hint Jeff King
2007-11-20 18:24 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120182233.GA3461@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).