git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Hausmann <simon@lst.de>
To: "Shun Kei Leung" <kevinlsk@gmail.com>
Cc: "Git ML" <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] git-p4: Fix typo in --detect-labels
Date: Wed, 21 Nov 2007 08:48:56 +0100	[thread overview]
Message-ID: <200711210848.59818.simon@lst.de> (raw)
In-Reply-To: <e66701d40711201901n712e17e6x6018a4dc16e75cea@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Wednesday 21 November 2007 04:01:19 Shun Kei Leung wrote:
> Signed-off-by: Kevin Leung <kevinlsk@gmail.com>

Acked-by: Simon Hausmann <simon@lst.de>



Thanks,
Simon

>  contrib/fast-import/git-p4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index 65c57ac..66b79b6 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1026,7 +1026,7 @@ class P4Sync(Command):
>
>          l = p4CmdList("labels %s..." % ' '.join (self.depotPaths))
>          if len(l) > 0 and not self.silent:
> -            print "Finding files belonging to labels in %s" %
> `self.depotPath` +            print "Finding files belonging to labels in
> %s" % `self.depotPaths`
>
>          for output in l:
>              label = output["label"]

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2007-11-21  7:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21  3:01 [PATCH] git-p4: Fix typo in --detect-labels Shun Kei Leung
2007-11-21  7:48 ` Simon Hausmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711210848.59818.simon@lst.de \
    --to=simon@lst.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevinlsk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).