From: Eric Wong <normalperson@yhbt.net>
To: Adam Roben <aroben@apple.com>
Cc: "David D. Kilzer" <ddkilzer@kilzer.net>, git@vger.kernel.org
Subject: Re: [PATCH 4/3] git-svn: allow `info' command to work offline
Date: Wed, 21 Nov 2007 19:56:05 -0800 [thread overview]
Message-ID: <20071122035605.GB30134@soma> (raw)
In-Reply-To: <4744F66D.7030007@apple.com>
Adam Roben <aroben@apple.com> wrote:
> Eric Wong wrote:
> >+ my $k = "svn-remote.$self->{repo_id}.reposRoot";
> >
>
> "repoRoot" seems slightly more intuitive than "reposRoot", given that
> "repository" is normally abbreviated as "repo".
>From a git-only point of view, yes. But it's repos_root everywhere
inside git-svn because SVN uses "*_repos_root" for their API.
This is inside the hidden metadata file that users
shouldn't have to touch anyways.
On a side note:
I personally *hate* camelCase names (or worse, alllowercase), but
git config doesn't allow underscores in config keys for some
strange reason (especially strange since most of the git and Linux
source code use snake_case...)
--
Eric Wong
prev parent reply other threads:[~2007-11-22 3:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 19:57 [PATCH 0/3 v3] Implement git-svn info David D. Kilzer
2007-11-21 19:57 ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions David D. Kilzer
2007-11-21 19:57 ` [PATCH 2/3 v3] git-svn info: implement info command David D. Kilzer
2007-11-21 19:57 ` [PATCH 3/3 v3] git-svn: info --url [path] David D. Kilzer
2007-11-22 1:40 ` [PATCH 2/3 v3] git-svn info: implement info command Eric Wong
2007-11-22 3:16 ` David D. Kilzer
2007-11-22 4:17 ` Eric Wong
2007-11-22 1:19 ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions Eric Wong
2007-11-22 2:23 ` [PATCH 4/3] git-svn: allow `info' command to work offline Eric Wong
2007-11-22 3:24 ` Adam Roben
2007-11-22 3:56 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071122035605.GB30134@soma \
--to=normalperson@yhbt.net \
--cc=aroben@apple.com \
--cc=ddkilzer@kilzer.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).