git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: "David D. Kilzer" <ddkilzer@kilzer.net>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3 v3] git-svn info: implement info command
Date: Wed, 21 Nov 2007 20:17:53 -0800	[thread overview]
Message-ID: <20071122041753.GC30134@soma> (raw)
In-Reply-To: <900537.19467.qm@web52411.mail.re2.yahoo.com>

"David D. Kilzer" <ddkilzer@kilzer.net> wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> > When running from a top-level directory with no arguments, the first
> > line of git-ls-tree was being read.  This allowed the test case to pass
> > because ls-tree sorts the output and 'directory' just happened to
> > be up top; so we were getting the 040000 mode from the 'directory'
> > tree and not the top-level tree.
> > 
> > The below test should fix it for the trivial case I have.
> 
> Acked-by: David D. Kilzer <ddkilzer@kilzer.net>
> 
> Looks good!  Thanks!

Ok, I've folded that into your [2/3] and pushed everything (and an
earlier fix) out to

	git://git.bogomips.org/git-svn.git

David D. Kilzer (3):
      git-svn: extract reusable code into utility functions
      git-svn info: implement info command
      git-svn: info --url [path]

Eric Wong (2):
      t9106: fix a race condition that caused svn to miss modifications
      git-svn: allow `info' command to work offline

Junio, please pull, thanks.

-- 
Eric Wong

  reply	other threads:[~2007-11-22  4:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 19:57 [PATCH 0/3 v3] Implement git-svn info David D. Kilzer
2007-11-21 19:57 ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions David D. Kilzer
2007-11-21 19:57   ` [PATCH 2/3 v3] git-svn info: implement info command David D. Kilzer
2007-11-21 19:57     ` [PATCH 3/3 v3] git-svn: info --url [path] David D. Kilzer
2007-11-22  1:40     ` [PATCH 2/3 v3] git-svn info: implement info command Eric Wong
2007-11-22  3:16       ` David D. Kilzer
2007-11-22  4:17         ` Eric Wong [this message]
2007-11-22  1:19   ` [PATCH 1/3 v3] git-svn: extract reusable code into utility functions Eric Wong
2007-11-22  2:23 ` [PATCH 4/3] git-svn: allow `info' command to work offline Eric Wong
2007-11-22  3:24   ` Adam Roben
2007-11-22  3:56     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071122041753.GC30134@soma \
    --to=normalperson@yhbt.net \
    --cc=ddkilzer@kilzer.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).