Re: [RFC/PATCH] Making ce_path_match() more useful by accepting globs

[Alex Riesen <raa.lkml@gmail.com>]

Junio C Hamano, Sun, Nov 25, 2007 21:35:18 +0100:
> Currently, these do not work:
> 
>    git diff-files 't/*.sh'
>    git diff-index HEAD 'xdiff/*.c'
>    git update-index -g 'Documentation/howto/*.txt'
> 
> This is because ce_path_match(), the underlying function that is used to
> see if a cache entry matches the set of pathspecs, only understands
> leading directory match.
> 
> This teaches ce_path_match() to use the match_pathspec() used in
> git-ls-files, which knows about glob patterns.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  [SORRY FOR A RESEND -- I screwed up the To: field of the previous message]
> 
>  * Having two different behaviours of pathspec matching has been
>    bothering me for quite some time.  The changes here look trivially
>    correct and the result passes all the tests, but this is quite close
>    to the core part of the system, and would benefit greatly from extra
>    set of eyes.

How about doing the same what was done with recursive directory
walker (no, I'm not confusing pathname filters with paths)? Always
have the glob expansion for porcelain (git-diff, git-log, git-show),
and add a command-line option to activate for plumbing?

(Well, the oldtimers as yourself will probably find it hard to
separate git-diff-tree from git-diff).